From: Yegor Yefremov <yegorslists@googlemail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-usb <linux-usb@vger.kernel.org>, Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH] USB: serial: add port statistics
Date: Wed, 18 Sep 2019 13:22:42 +0200 [thread overview]
Message-ID: <CAGm1_kvb--Ckxxft=Nqx4GDoHhA_qU3+ZCoqF86dEua_V2VrtA@mail.gmail.com> (raw)
In-Reply-To: <20190918110814.GC1894362@kroah.com>
On Wed, Sep 18, 2019 at 1:08 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Wed, Sep 18, 2019 at 11:14:15AM +0200, yegorslists@googlemail.com wrote:
> > From: Yegor Yefremov <yegorslists@googlemail.com>
> >
> > Add additional port statistics like received and transmitted bytes
> > the way /proc/tty/driver/serial does.
> >
> > As usbserial driver already provides USB related information and
> > this line is longer than 100 characters, this patch adds an
> > additional line with the same port number:
> >
> > 0: module:ftdi_sio name:"FTDI USB Serial Device" vendor:0403 ...
> > 0: tx:112 rx:0
> >
> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> > ---
> > drivers/usb/serial/usb-serial.c | 22 ++++++++++++++++++++++
> > 1 file changed, 22 insertions(+)
>
> You can't change existing proc files without having the chance that
> userspace tools will break.
>
> Have you tried this and seen what dies a horrible death?
This patch is more a proof of concept (forgot to add RFC keyword). I
find statistics provdes by the 8250 driver very useful for debugging
purposes. What would be the best way to implemnt this feature for
usbserial driver?
a) extend current line:
0: module:ftdi_sio name:"FTDI USB Serial Device" vendor:0403 ...tx:112 rx:0
though this still can break parsing
b) creating special entries for FTDI and other UARTs? Though it would
be greate to have all usbserial UART handled the same way in the same
file
Best regards,
Yegor
next prev parent reply other threads:[~2019-09-18 11:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 9:14 [PATCH] USB: serial: add port statistics yegorslists
2019-09-18 11:08 ` Greg KH
2019-09-18 11:22 ` Yegor Yefremov [this message]
2019-09-18 11:45 ` Greg KH
2019-09-18 11:51 ` Yegor Yefremov
2019-09-18 12:02 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGm1_kvb--Ckxxft=Nqx4GDoHhA_qU3+ZCoqF86dEua_V2VrtA@mail.gmail.com' \
--to=yegorslists@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).