From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: chenyu56@huawei.com
Cc: USB <linux-usb@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Suzhuangluan <suzhuangluan@hisilicon.com>,
Kongfei <kongfei@hisilicon.com>, Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
John Stultz <john.stultz@linaro.org>,
Wangbinghui <wangbinghui@hisilicon.com>
Subject: [v1,11/12] usb: gadget: Add configfs attribuite for controling match_existing_only
Date: Mon, 3 Dec 2018 11:25:36 +0200 [thread overview]
Message-ID: <CAHp75VcUQN_PuXDVkeR+jagTsUaOWLtytVt+f_eR+x2iw9B5-A@mail.gmail.com> (raw)
On Mon, Dec 3, 2018 at 5:47 AM Yu Chen <chenyu56@huawei.com> wrote:
>
> Currently the "match_existing_only" of usb_gadget_driver in configfs is
> set to one which is not flexible.
> Dwc3 udc will be removed when usb core switch to host mode. This causes
> failure of writing name of dwc3 udc to configfs's UDC attribuite.
> To fix this we need to add a way to change the config of
> "match_existing_only".
> This patch adds a configfs attribuite for controling match_existing_only
> which allow user to config "match_existing_only".
> +static ssize_t gadget_driver_match_existing_only_store(struct config_item *item,
> + const char *page, size_t len)
> +{
> + struct usb_gadget_driver *gadget_driver =
> + &(to_gadget_info(item)->composite.gadget_driver);
It would be easier for reader to see two lines with two variables
instead of this.
> + bool match_existing_only;
> + int ret;
> +
> + ret = kstrtobool(page, &match_existing_only);
> + if (ret)
> + return ret;
> +
> + if (match_existing_only)
> + gadget_driver->match_existing_only = 1;
> + else
> + gadget_driver->match_existing_only = 0;
gadget_driver->match_existing_only = match_existing_only;
But the question rather why is it not direct parameter to kstrtobool?
> +
> + return len;
> +}
> + struct usb_gadget_driver *gadget_driver =
> + &(to_gadget_info(item)->composite.gadget_driver);
Make it neat.
next reply other threads:[~2018-12-03 9:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 9:25 Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-12-04 1:22 [v1,11/12] usb: gadget: Add configfs attribuite for controling match_existing_only Yu Chen
2018-12-03 9:53 Krzysztof Opasiak
2018-12-03 3:45 Yu Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcUQN_PuXDVkeR+jagTsUaOWLtytVt+f_eR+x2iw9B5-A@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=balbi@kernel.org \
--cc=chenyu56@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=kongfei@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=suzhuangluan@hisilicon.com \
--cc=wangbinghui@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).