From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Daniel Drake <drake@endlessm.com>
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Linux USB Mailing List <linux-usb@vger.kernel.org>,
Linux PCI <linux-pci@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Endless Linux Upstreaming Team <linux@endlessm.com>
Subject: Re: Ryzen7 3700U xhci fails on resume from sleep
Date: Tue, 27 Aug 2019 09:48:09 +0200 [thread overview]
Message-ID: <CAJZ5v0gouaztf7tcKXBr90gjrVjOvqH70regD=o2r_d+9Bwvqg@mail.gmail.com> (raw)
In-Reply-To: <CAD8Lp4658-c=7KabiJ=xuNRCqPwF4BJauMHqh_8WSBfCFHWSSg@mail.gmail.com>
On Tue, Aug 27, 2019 at 4:50 AM Daniel Drake <drake@endlessm.com> wrote:
>
> On Mon, Aug 26, 2019 at 9:32 PM Mathias Nyman
> <mathias.nyman@linux.intel.com> wrote:
> > On 26.8.2019 12.29, Rafael J. Wysocki wrote:
> > > I wonder if you can reproduce this with the pm-s2idle-rework branch
> > > from linux-pm.git merged in.
> >
> > Root cause looks similar to:
> > https://bugzilla.kernel.org/show_bug.cgi?id=203885
> >
> > Mika wrote a fix for that:
> > https://lore.kernel.org/linux-pci/20190821124519.71594-1-mika.westerberg@linux.intel.com/
>
> Thanks for the suggestions. Mika's patch was already applied then
> reverted, I applied it again but there's no change.
> Also merging in pm-s2idle-rework doesn't make any difference.
>
> Any other ideas? Or comments on my findings so far?
> Given that I can't shift D0-D3-D0 reliably directly with setpci before
> loading the driver, is that indicative of a fundamental problem with
> the platform, or is my test invalid?
That depends on what exactly happens when you try to do the D0-D3-D0
with setpci. If the device becomes unreachable (or worse) after that,
it indicates a platform issue. It should not do any harm at the
least.
However, in principle D0-D3-D0 at the PCI level alone may not be
sufficient, because ACPI may need to be involved.
I think that PM-runtime should suspend XHCI controllers without
anything on the bus under them, so I wonder what happens if
".../power/control" is set to "on" and then to "auto" for that device,
with the driver loaded.
> Or in terms of other ways of testing the power transition outside of
> the suspend path, if a PCI dev is runtime suspended with no driver
> loaded, should Linux not be attempting to put it into D3?
PCI devices without drivers cannot be runtime-suspended at all.
Cheers,
Rafael
next prev parent reply other threads:[~2019-08-27 7:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 9:10 Ryzen7 3700U xhci fails on resume from sleep Daniel Drake
2019-08-26 9:29 ` Rafael J. Wysocki
2019-08-26 13:34 ` Mathias Nyman
2019-08-27 2:49 ` Daniel Drake
2019-08-27 7:48 ` Rafael J. Wysocki [this message]
2019-08-28 8:34 ` Daniel Drake
2019-08-28 8:43 ` Rafael J. Wysocki
2019-08-29 7:33 ` Daniel Drake
2019-09-23 9:10 ` Daniel Drake
2019-09-25 5:36 ` Daniel Drake
2019-10-08 5:42 ` Daniel Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0gouaztf7tcKXBr90gjrVjOvqH70regD=o2r_d+9Bwvqg@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=drake@endlessm.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=mathias.nyman@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).