From: Zheng Hacker <hackerzheng666@gmail.com>
To: Zheng Wang <zyytlz.wz@163.com>
Cc: valentina.manea.m@gmail.com, shuah@kernel.org,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, 1395428693sheep@gmail.com,
alex000young@gmail.com
Subject: Re: [PATCH v3] usbip: vudc: Fix use after free bug in vudc_remove due to race condition
Date: Fri, 17 Mar 2023 01:47:35 +0800 [thread overview]
Message-ID: <CAJedcCz1+0ceVSjhnLwjDODcqPYLGPB1MEfFeTyrw0KH3e-0Qw@mail.gmail.com> (raw)
In-Reply-To: <20230316174432.1592087-1-zyytlz.wz@163.com>
Sorry this is not v3 but v1, I will resubmit v1 again. Sorry again for
my mistake.
Thanks,
Zheng
Zheng Wang <zyytlz.wz@163.com> 于2023年3月17日周五 01:44写道:
>
> In vudc_probe, it calls init_vudc_hw, which bound &udc->timer with v_timer.
>
> When it calls usbip_sockfd_store, it will call v_start_timer to start the
> timer work.
>
> When we call vudc_remove to remove the driver, theremay be a sequence as
> follows:
>
> Fix it by shutdown the timer work before cleanup in vudc_remove.
>
> Note that removing a driver is a root-only operation, and should never
> happen.
>
> CPU0 CPU1
>
> |v_timer
> vudc_remove |
> kfree(udc); |
> //free shost |
> |udc->gadget
> |//use
>
> Fixes: b6a0ca111867 ("usbip: vudc: Add UDC specific ops")
> Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
> ---
> drivers/usb/usbip/vudc_dev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c
> index 2bc428f2e261..33d0991755bb 100644
> --- a/drivers/usb/usbip/vudc_dev.c
> +++ b/drivers/usb/usbip/vudc_dev.c
> @@ -633,6 +633,7 @@ int vudc_remove(struct platform_device *pdev)
> {
> struct vudc *udc = platform_get_drvdata(pdev);
>
> + timer_shutdown_sync(&udc->timer);
> usb_del_gadget_udc(&udc->gadget);
> cleanup_vudc_hw(udc);
> kfree(udc);
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-03-16 17:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 17:44 [PATCH v3] usbip: vudc: Fix use after free bug in vudc_remove due to race condition Zheng Wang
2023-03-16 17:47 ` Zheng Hacker [this message]
2023-03-16 17:57 ` Shuah Khan
2023-03-16 18:02 ` Zheng Hacker
2023-03-17 10:09 Zheng Wang
2023-03-17 22:53 ` Shuah Khan
2023-03-18 7:39 ` Zheng Hacker
2023-04-13 8:09 ` Zheng Hacker
2023-04-13 18:01 ` Shuah Khan
2023-04-14 2:33 ` Zheng Hacker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJedcCz1+0ceVSjhnLwjDODcqPYLGPB1MEfFeTyrw0KH3e-0Qw@mail.gmail.com \
--to=hackerzheng666@gmail.com \
--cc=1395428693sheep@gmail.com \
--cc=alex000young@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=valentina.manea.m@gmail.com \
--cc=zyytlz.wz@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).