From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2094C32758 for ; Fri, 9 Aug 2019 14:20:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A314E21783 for ; Fri, 9 Aug 2019 14:20:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407100AbfHIOUD (ORCPT ); Fri, 9 Aug 2019 10:20:03 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:41046 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726232AbfHIOUD (ORCPT ); Fri, 9 Aug 2019 10:20:03 -0400 Received: by mail-qk1-f194.google.com with SMTP id g17so1061588qkk.8; Fri, 09 Aug 2019 07:20:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iqpS6f4iYT2/EOjyhlDBwimFIDoQ2vjPU9zyXzeymVs=; b=tgGY1n0aBq1wKRyOE9mbT7s3RsuCu6FgHAPajrNs49W6xNDNuuAvZ3HM4L/hXgys30 QLAl3mnAEJtFOeRw0fAmJ3LdBx9nq05hQzg6knN7Znykfb3fvo2IKs+zjhUQS6cqpQ22 ijEhehP3zy+v71aQfpVYsClxRfSlxGL1afgYfvjqNRkOjk6HDu6IudEsXfphJTGM9srJ 1cf1PFaTftLzRizDDHjfVsAfDksMVPT8I8y9TjWH3YbXUoT36edrLBuPhlKaYMmFvASN YVVEEv+FOIq6FRRJYScZoLazV2uYwS9UDTEkuhjW53AHvuB1d1WadYnxXGpeWrLEZO3x JdOg== X-Gm-Message-State: APjAAAXDxVeskRlnapr5AGSYvOW7zYvbLNyU2j9d+P3tgbQ2sICMtZW8 gXGXkxW76cxl4mqtx5W0BbbONm+N7oOR9WnLzeo= X-Google-Smtp-Source: APXvYqy/OT0e+ifcdg76ad6xNKU9QCStCMIG/+ooQXzRuWl//U3NqYzpdPro7Befy76nezGoQdOa5mEAGNXNhGehJZQ= X-Received: by 2002:a37:4ac3:: with SMTP id x186mr17754552qka.138.1565360402354; Fri, 09 Aug 2019 07:20:02 -0700 (PDT) MIME-Version: 1.0 References: <20190731195713.3150463-1-arnd@arndb.de> <20190731195713.3150463-6-arnd@arndb.de> In-Reply-To: From: Arnd Bergmann Date: Fri, 9 Aug 2019 16:19:46 +0200 Message-ID: Subject: Re: [PATCH 05/14] gpio: lpc32xx: allow building on non-lpc32xx targets To: Sylvain Lemieux Cc: soc@kernel.org, "moderated list:ARM PORT" , Vladimir Zapolskiy , Russell King , Gregory Clement , Linus Walleij , Bartosz Golaszewski , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , "David S. Miller" , Greg Kroah-Hartman , Alan Stern , Guenter Roeck , "open list:GPIO SUBSYSTEM" , Networking , linux-serial@vger.kernel.org, USB list , LINUXWATCHDOG , Lee Jones , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Aug 6, 2019 at 10:02 PM Sylvain Lemieux wrote: > > > > + gpio_reg_base = devm_platform_ioremap_resource(pdev, 0); > > + if (gpio_reg_base) > > + return -ENXIO; > > The probe function will always return an error. > Please replace the previous 2 lines with: > if (IS_ERR(gpio_reg_base)) > return PTR_ERR(gpio_reg_base); > > You can add my acked-by and tested-by in the v2 patch. > Acked-by: Sylvain Lemieux > Tested-by: Sylvain Lemieux Ok, fixed now, along with addressing Bartosz' concerns. Arnd