From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DADFC2D0A3 for ; Thu, 29 Oct 2020 10:46:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 007DA20790 for ; Thu, 29 Oct 2020 10:46:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LIzvOJMK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727047AbgJ2KqE (ORCPT ); Thu, 29 Oct 2020 06:46:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726528AbgJ2KqD (ORCPT ); Thu, 29 Oct 2020 06:46:03 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8BE2C0613CF for ; Thu, 29 Oct 2020 03:46:02 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id x16so2587238ljh.2 for ; Thu, 29 Oct 2020 03:46:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xiHfCffOCyIyuoQviGVjPYyBZGKXlLGUiHIMR4DC1pY=; b=LIzvOJMKi2D42fV8TK8AnRVDKA3u1xab7aGfn3isrwWnStOBGdujL5YSLNRl68VULp aW31X2S8p3lu6uzvChmJlhWniQsEOu1C5FkWQhHRi6XdPYt6ss3VRdpXQZciMhbQ3P8Z LkQ9W0pyAdGR+0EZspAQ8WKulsd1dZHGZwWjW00uyRqs8EG6yXnjgJtGZGjMPXkDKXO3 UqhbkheEmMozxFYNzWvj6SQB4mYgAk1GG8aNb/VkUhDyndc83zCdxqnjc5pXqfkldHgE OWHdS4nnxx6SBWQWS7jAVcfdZRq8q74hu3QwZAlAyA1twlNxmYTlWWIlsW7QXk25vpnc dGuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xiHfCffOCyIyuoQviGVjPYyBZGKXlLGUiHIMR4DC1pY=; b=iZ7RVxd0nXZ9TXNMshy6eIK6A8fgqL+lPH4Q3v3myNTWLUd0tME95BH7sRlCwBxgf0 +kGH+UGvk9j83SWRvIK3NmxB40tifPyu9eH84YHLCiK/2EDABtE2jkFKvSLAxgcmQGGI nXxZFNrmVfOQNqaRpt4/QwT/mfQ7H6ShmoVKAV303G7FPeNKjOWPDwR7L7TBdE45DHsF 4dfmsniDz17A2z7z9e4bpMuFvTwU467it4IEVGSow+OtTrhldlnp2Fs9zAyRNeXJI0mb pH8JNiWNesh/UsJ8O/6g9hy7ZMLYc2lofg1L3QhEGm7lrUpwi1fcLElSoOwfXOqcLXXT Fbpg== X-Gm-Message-State: AOAM531HVSCtAUBQ+Wk7ycpJwvSPydIxhfondQtbjXWV2m9Z2htRBp+h 8k3wuSf7Hh9HyAvDpCkTYaUSGQQ8C3SjvgL16C4= X-Google-Smtp-Source: ABdhPJwISF3a5+E95KykwEN5ArDIZzUANErM+wA6Zo493PqRtpeI60SEu31uZ+DJOS39GqdEejiP3feydo93CTgVNh8= X-Received: by 2002:a2e:b5d2:: with SMTP id g18mr1611648ljn.211.1603968361180; Thu, 29 Oct 2020 03:46:01 -0700 (PDT) MIME-Version: 1.0 References: <20201013092746.10602-1-peter.chen@nxp.com> <20201013092746.10602-2-peter.chen@nxp.com> In-Reply-To: <20201013092746.10602-2-peter.chen@nxp.com> From: Peter Chen Date: Thu, 29 Oct 2020 18:45:49 +0800 Message-ID: Subject: Re: [PATCH RESEND 2/2] usb: gadget: core: do not try to disconnect gadget if it is not connected To: Peter Chen Cc: balbi@kernel.org, USB list , linux-imx@nxp.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Oct 13, 2020 at 8:01 PM Peter Chen wrote: > > Current UDC core connects gadget during the loading gadget flow > (udc_bind_to_driver->usb_udc_connect_control), but for > platforms which do not connect gadget if the VBUS is not there, > they call usb_gadget_disconnect, but the gadget is not connected > at this time, notify disconnecton for the gadget driver is meaningless > at this situation. > > Signed-off-by: Peter Chen > --- > drivers/usb/gadget/udc/core.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c > index 215ecbe8b692..8ad4203dea8c 100644 > --- a/drivers/usb/gadget/udc/core.c > +++ b/drivers/usb/gadget/udc/core.c > @@ -672,6 +672,9 @@ int usb_gadget_connect(struct usb_gadget *gadget) > goto out; > } > > + if (!gadget->connected) > + goto out; > + > if (gadget->deactivated) { > /* > * If gadget is deactivated we only save new state. > -- > 2.17.1 > A gentle ping. Peter