From: John Stultz <john.stultz@linaro.org>
To: Roger Quadros <rogerq@ti.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Yu Chen <chenyu56@huawei.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Felipe Balbi <balbi@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Jun Li <lijun.kernel@gmail.com>,
Valentin Schneider <valentin.schneider@arm.com>,
Linux USB List <linux-usb@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [RFC][PATCH 3/3] usb: dwc3: Registering a role switch in the DRD code.
Date: Tue, 15 Oct 2019 12:10:22 -0700 [thread overview]
Message-ID: <CALAqxLUVd5Eo_9tuP9aQUpNT0gnewBv8Dpvsj8UT3MucmzCJVQ@mail.gmail.com> (raw)
In-Reply-To: <9e86bb7b-5dd2-760e-c324-fe1c1ee41868@ti.com>
On Tue, Oct 15, 2019 at 1:25 AM Roger Quadros <rogerq@ti.com> wrote:
> On 03/10/2019 02:16, John Stultz wrote:
> > @@ -487,7 +539,28 @@ int dwc3_drd_init(struct dwc3 *dwc)
> > if (IS_ERR(dwc->edev))
> > return PTR_ERR(dwc->edev);
> >
> > - if (dwc->edev) {
> > + if (device_property_read_bool(dwc->dev, "usb-role-switch")) {
>
> I think we should use role switch unconditionally and get rid of the
> debugfs role status/change mechanism.
>
> > + struct usb_role_switch_desc dwc3_role_switch = {0};
> > + u32 mode;
> > +
> > + if (device_property_read_bool(dwc->dev,
> > + "role-switch-default-host")) {
> > + dwc->role_switch_default_mode = USB_DR_MODE_HOST;
> > + mode = DWC3_GCTL_PRTCAP_HOST;
> > + } else {
> > + dwc->role_switch_default_mode = USB_DR_MODE_PERIPHERAL;
> > + mode = DWC3_GCTL_PRTCAP_DEVICE;
> > + }
> > + dwc3_role_switch.fwnode = dev_fwnode(dwc->dev);
> > + dwc3_role_switch.set = dwc3_usb_role_switch_set;
> > + dwc3_role_switch.get = dwc3_usb_role_switch_get;
> > + dwc->role_sw = usb_role_switch_register(dwc->dev,
> > + &dwc3_role_switch);
> > + if (IS_ERR(dwc->role_sw))
> > + return PTR_ERR(dwc->role_sw);
> > +
> > + dwc3_set_mode(dwc, mode);
> > + } else if (dwc->edev) {
>
> Role switch should exist regardless if dwc->edev is present or not.
Does that risk duplicative mode sets when things change (via the
dwc3_drd_notifier and dwc3_usb_role_switch_set calls?).
thanks
-john
next prev parent reply other threads:[~2019-10-15 19:10 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 23:16 [RFC][PATCH 0/3] dwc3 role-switch handling for HiKey960 John Stultz
2019-10-02 23:16 ` [RFC][PATCH 1/3] dt-bindings: usb: generic: Add role-switch-default-host binding John Stultz
2019-10-02 23:16 ` [RFC][PATCH 2/3] usb: roles: Add usb role switch notifier John Stultz
2019-10-03 9:25 ` Hans de Goede
2019-10-03 20:37 ` John Stultz
2019-10-03 20:51 ` Hans de Goede
2019-10-04 8:12 ` Heikki Krogerus
2019-10-15 5:39 ` John Stultz
2019-10-16 7:27 ` Hans de Goede
2019-10-18 5:55 ` John Stultz
2019-10-18 8:06 ` Hans de Goede
2019-10-18 18:39 ` John Stultz
2019-10-18 19:30 ` Hans de Goede
2019-10-18 19:53 ` John Stultz
2019-10-18 19:59 ` Hans de Goede
2019-10-18 20:12 ` John Stultz
2019-10-18 20:21 ` Hans de Goede
2019-10-18 20:37 ` John Stultz
2019-10-18 21:05 ` Hans de Goede
2019-10-22 5:58 ` John Stultz
2019-11-14 10:11 ` Hans de Goede
2019-11-15 0:23 ` John Stultz
2019-10-16 9:10 ` Hans de Goede
2019-10-03 11:26 ` Greg Kroah-Hartman
2019-10-03 20:45 ` John Stultz
2019-10-03 20:56 ` Hans de Goede
2019-10-03 21:33 ` John Stultz
2019-10-06 15:22 ` Hans de Goede
2019-10-15 7:03 ` John Stultz
2019-10-04 8:00 ` Heikki Krogerus
2019-10-02 23:16 ` [RFC][PATCH 3/3] usb: dwc3: Registering a role switch in the DRD code John Stultz
2019-10-15 8:25 ` Roger Quadros
2019-10-15 19:10 ` John Stultz [this message]
2019-10-16 9:24 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALAqxLUVd5Eo_9tuP9aQUpNT0gnewBv8Dpvsj8UT3MucmzCJVQ@mail.gmail.com \
--to=john.stultz@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=balbi@kernel.org \
--cc=chenyu56@huawei.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=lijun.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=suzuki.poulose@arm.com \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).