From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C3CDCA9EA0 for ; Fri, 18 Oct 2019 18:39:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0BE8C21925 for ; Fri, 18 Oct 2019 18:39:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="f1TWdlYa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2505870AbfJRSjU (ORCPT ); Fri, 18 Oct 2019 14:39:20 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:53008 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2505856AbfJRSjU (ORCPT ); Fri, 18 Oct 2019 14:39:20 -0400 Received: by mail-wm1-f68.google.com with SMTP id r19so7169808wmh.2 for ; Fri, 18 Oct 2019 11:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=f4CnMsn4AbSRNn1EVCaabWmq8sv54L0ZTWdVo5HeLwA=; b=f1TWdlYaruRtAyn1ngSsZ6uQn90ArDxO5LBV1SCnegvCTBjunLuFQdCC5GQcOic5kV XFX4SOPayd3RrflTHaz9+t1hM4dPpdExngdo3PnFxk5kowUq+zvTsVLEbj2AUks6p20x iQHFEDttYjw/iF8/w/yPlasZfFcKXzwcThXlvx8iXO6IZu/+6bD9Si5igH998rahS9kD wCtSdgazQwuBZ7W127ThETW+39wbFdle7JTJlO+jOfYJ/a4KN4EGaVf7O2oRqubH7fEQ XdqNT2/L8jTS95upwtA+kgQwGiJxlXO8kpGvnzsiPJcVm/lBKiwBaH9+SueZ4aw1uEBh zaoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=f4CnMsn4AbSRNn1EVCaabWmq8sv54L0ZTWdVo5HeLwA=; b=hHn/1zU0MqDTqtWnf6UrgyHc/zB0PPUIbz996QMAc9qc4BCpgW9MySZGvAKGes3gc2 RY29TD6Cq24qe9JdLEzkcEc7N0NKCbTq1njvrRz5MCvyJ+2rwWNByqnA8SyVoxlB3cA3 9qWio2t560ZES2pq6i7ET8jy5mjpkE/um8SGpRgJ+hr+sTmWutcASLb84/FUZvGPVTNV rCxO3eZi4nbtEHvtM606gtMpsmI3SZQXjPT8f4AGJjHgM/3ZdSU3OEy0DbwvwH/ek+eh jjahH27XR1O6ving37e66e8klc2AMPZ7HsHfMPlGIrtJeUMJt/qNnfyknn2nLRMej08G 7Ahg== X-Gm-Message-State: APjAAAW5A2SGn/M2FEB74PViHbOf6ibY03fhUdbtK2EyIv4v019mC5cQ RSwO1VQ16cnNFcMaUCRG020VBIXNSOokBgwAR6fDYQ== X-Google-Smtp-Source: APXvYqwQBRN+0AP3sy+6+jMt6ece72V8onGhRTBZvT/3iOom/I8z+sXUkSfEcU0M5YrBcGzh2NdoipI884i3PRHW/D4= X-Received: by 2002:a1c:f201:: with SMTP id s1mr8322752wmc.59.1571423957896; Fri, 18 Oct 2019 11:39:17 -0700 (PDT) MIME-Version: 1.0 References: <20191002231617.3670-1-john.stultz@linaro.org> <20191002231617.3670-3-john.stultz@linaro.org> <2e369349-41f6-bd15-2829-fa886f209b39@redhat.com> <648e2943-42f5-e07d-5bb4-f6fd8b38b726@redhat.com> In-Reply-To: From: John Stultz Date: Fri, 18 Oct 2019 11:39:06 -0700 Message-ID: Subject: Re: [RFC][PATCH 2/3] usb: roles: Add usb role switch notifier. To: Hans de Goede Cc: lkml , Yu Chen , Greg Kroah-Hartman , Rob Herring , Mark Rutland , Heikki Krogerus , Suzuki K Poulose , Chunfeng Yun , Felipe Balbi , Andy Shevchenko , Jun Li , Valentin Schneider , Linux USB List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri, Oct 18, 2019 at 1:06 AM Hans de Goede wrote: > On 18-10-2019 07:55, John Stultz wrote: > > On Wed, Oct 16, 2019 at 12:27 AM Hans de Goede wrote: > >> Look at the tcpm_set_vbus implementation in drivers/usb/typec/tcpm/fusb302.c > >> you need to do something similar in your Type-C controller driver and > >> export the GPIO as as a gpio-controlled regulator and tie the regulator to > >> the connector. > > > > Thanks for the suggestion, I really appreciate it! One more question > > though, since I'm using the tcpci_rt1711h driver, which re-uses the > > somewhat sparse tcpci.c implementation, would you recommend trying to > > add generic regulator support to the tcpci code or trying to extend > > the implementation somehow allow the tcpci_rt1711h driver replace just > > the set_vbus function? > > I have the feeling that this is more of a question for Heikki. > > My first instinct is: if you are using tcpci can't you put all > the hacks you need for the usb connection shared between hub > and type-c in your firmware ? I appreciate the suggestion, but I'm not aware of any USB firmware for the board, nor do I think I have any such source. :( thanks -john