From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A41B2C3A59D for ; Fri, 16 Aug 2019 07:39:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8570920644 for ; Fri, 16 Aug 2019 07:39:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726820AbfHPHjP (ORCPT ); Fri, 16 Aug 2019 03:39:15 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:36561 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726425AbfHPHjP (ORCPT ); Fri, 16 Aug 2019 03:39:15 -0400 Received: by mail-ot1-f67.google.com with SMTP id k18so8886054otr.3; Fri, 16 Aug 2019 00:39:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rNgiwRT8IqruHTtyg4qTM81WOjWWtlc2s7dRDLMNYXA=; b=on2SQVhJOHdWQEc2H0aF4Jqh7WDKMaXEPJG0U44YSRI2ocAwWxoXKuH2/IozeNBHrn RRsomVVULDyN4ka0XyJ3p0LL06HWLk4zps+lQyUsuN8bGL5vDSfV3ZJtTv8y29oqQ25I ayiVC4RDsQiNyNyXqS9ncR36jlfkDPI7eOIRX9RdqNsKEB67cqfpi5SEPEq/PhLVVEHT kWo7XRXgls6Ie27GjuPtsA4kr7DqdpQsXZHlNGBbonWzZsluRfad9zMN/tbC2dxLNbOa 9wjJ4ueGJ6XdT6lo+dZOkjbcsPjeVVSFgZ4k+agXVPLlJMvzL+5vCFslH8BJJOrdnaky UPoA== X-Gm-Message-State: APjAAAUTYusEKAqYIKMSacN1O2sFRtHtSqJVLJnBfLEuwXrRO3Ii+QQW 9U4jvzNBC757WAlWPqcnfnt7irBVh++8Jx6y98kC7voz X-Google-Smtp-Source: APXvYqz193ixgGnhQHDM0sA58o87yH16orCv5VbCTsKEDkS808wZnFykFKzgKwDR213pxnj04zPYszKH8AWAfSfEEwQ= X-Received: by 2002:a9d:68c5:: with SMTP id i5mr6603053oto.250.1565941154237; Fri, 16 Aug 2019 00:39:14 -0700 (PDT) MIME-Version: 1.0 References: <20190816062435.881-1-hch@lst.de> <20190816062435.881-7-hch@lst.de> In-Reply-To: <20190816062435.881-7-hch@lst.de> From: Geert Uytterhoeven Date: Fri, 16 Aug 2019 09:39:03 +0200 Message-ID: Subject: Re: [PATCH 6/6] driver core: initialize a default DMA mask for platform device To: Christoph Hellwig Cc: Greg Kroah-Hartman , Maxime Chevallier , Gavin Li , Laurentiu Tudor , Minas Harutyunyan , Alan Stern , Geoff Levand , Michal Simek , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Mathias Nyman , Bin Liu , Linux ARM , USB list , linuxppc-dev , linux-m68k , Linux IOMMU , Linux-Arch , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi Christoph, On Fri, Aug 16, 2019 at 8:30 AM Christoph Hellwig wrote: > We still treat devices without a DMA mask as defaulting to 32-bits for > both mask, but a few releases ago we've started warning about such > cases, as they require special cases to work around this sloppyness. > Add a dma_mask field to struct platform_device so that we can initialize > the dma_mask pointer in struct device and initialize both masks to > 32-bits by default, replacing similar functionality in m68k and > powerpc. The arch_setup_pdev_archdata hooks is now unused and removed. > > Note that the code looks a little odd with the various conditionals > because we have to support platform_device structures that are > statically allocated. > > Signed-off-by: Christoph Hellwig > --- > arch/m68k/kernel/dma.c | 9 ------- Acked-by: Geert Uytterhoeven > arch/sh/boards/mach-ecovec24/setup.c | 2 -- > arch/sh/boards/mach-migor/setup.c | 1 - Acked-by: Geert Uytterhoeven given "[PATCH 0/2] Remove calls to empty arch_setup_pdev_archdata()" https://lore.kernel.org/linux-renesas-soc/1526641611-2769-1-git-send-email-geert+renesas@glider.be/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds