From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Anirudh Rayabharam <mail@anirudhrb.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
syzbot+7c2bb71996f95a82524c@syzkaller.appspotmail.com,
Linux USB Mailing List <linux-usb@vger.kernel.org>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usbhid: fix info leak in hid_submit_ctrl
Date: Wed, 5 May 2021 15:47:36 +0200 [thread overview]
Message-ID: <CAO-hwJJKyLT4iG4DEhXGREPLVU8UASB8_gOFULmQ7hx2dYG7uw@mail.gmail.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.2105051528090.28378@cbobk.fhfr.pm>
On Wed, May 5, 2021 at 3:28 PM Jiri Kosina <jikos@kernel.org> wrote:
>
> On Wed, 5 May 2021, Benjamin Tissoires wrote:
>
> > I don't have a reproducer like syzbot has for the exact bug here, as I
> > am relying on one real USB device to check if usbhid is not too broken.
> > However, the test suite should catch if there is an error implied by the
> > hid_report_len() change.
>
> Yes, that was exactly what I wanted to check, sorry for not being verbose
> enough :)
>
> > Anyway, I manually started the job and will report when it is done.
>
Heh, no problems.
"Job succeeded" \o/
Given that you are on a spree:
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
next prev parent reply other threads:[~2021-05-05 13:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-25 17:33 [PATCH] usbhid: fix info leak in hid_submit_ctrl Anirudh Rayabharam
2021-05-05 12:42 ` Jiri Kosina
2021-05-05 13:25 ` Benjamin Tissoires
2021-05-05 13:28 ` Jiri Kosina
2021-05-05 13:47 ` Benjamin Tissoires [this message]
2021-05-05 13:52 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO-hwJJKyLT4iG4DEhXGREPLVU8UASB8_gOFULmQ7hx2dYG7uw@mail.gmail.com \
--to=benjamin.tissoires@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@anirudhrb.com \
--cc=syzbot+7c2bb71996f95a82524c@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).