From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF3ACC43219 for ; Fri, 1 Oct 2021 13:39:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCA1661AA4 for ; Fri, 1 Oct 2021 13:39:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353610AbhJANle (ORCPT ); Fri, 1 Oct 2021 09:41:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231699AbhJANlc (ORCPT ); Fri, 1 Oct 2021 09:41:32 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9043AC061775 for ; Fri, 1 Oct 2021 06:39:48 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id y26so39173153lfa.11 for ; Fri, 01 Oct 2021 06:39:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EjEzezsR+/PambgN+lAAYZ1z9rojBWgi6PT34tsYxbI=; b=C6fV4yWw1ceIqlo3pLFwCxKnhVCw/kuzIb7ecScYvV7TNg4eT2p4ZPgCXRjlPQxuCS Wdr/7z3822oHu/gKY7pb2CMDmwChG2MImExZ3SoiaWINyTtW1mjxzlIHKKJVuIYKx8hL XXDlmZ7O6Q9suRQD3j6+xskiuv0wxvOHMTdBDNCKErUgilJvcT2E9jxQ+bUfhhOn3Zl2 PegGBhq5uW1fZcmpSDj8XwDwrskqlXtJCleoq2gIF4EIY51y2Y2nzExVxEGZFUBtMPZS 64vraK/EdUmAWqAarHFzUdqeZf01jrOztwUyhU1RKUkqlXcaOnw2/6iNrgizwk96n/W6 ZSQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EjEzezsR+/PambgN+lAAYZ1z9rojBWgi6PT34tsYxbI=; b=GAOZlHenyGa3/nwhP8Ky4iGUKvFKJ//7ckFrDkRXirW3Z1leMJvp2Kvxv6P2tA0zPt 8Sr1bbtx3uL1IZzHLPcGPHrNMO7UC6K4bdAsl94j+QQsj2P/dftk+GTgGHHkwSEJ2PWP db2O0elR8sWvMTgJto73Kw07nsZOdEIWpCHjrylJq0h3ozTCr9QB/L74RC6Ok/gH5rqU M/FnN9RRF+ymtOhc6bbBCn2PnfovQHnbVsAn6VzJd2ZaGuOcnrIZujBjPyUoGAvAVQws zkChKvJWnhlLOiwDoNHE7xx6Gdql5gD1cZrS+ZD2LqzKT4UiFHK4vQRGiIpJPLojUl1S /ReQ== X-Gm-Message-State: AOAM532dQSwJC5F5wdUq0hQN4rmYn7aJRywPDzHV49HISb6zs5ENpIX/ 8sHQBTDPIOskKzlSAbBUnxYU2gYYJORsDjTBZufYfw== X-Google-Smtp-Source: ABdhPJxp4p0UQRRIw2z72BWkWXdCGpyRnefweou3T6S9p6407CeSYXpm2W/gIhkCapLJ10cfY553xwNF/HrJa5MfNR0= X-Received: by 2002:a05:651c:2006:: with SMTP id s6mr12122181ljo.4.1633095586851; Fri, 01 Oct 2021 06:39:46 -0700 (PDT) MIME-Version: 1.0 References: <20210926224058.1252-1-digetx@gmail.com> <20210926224058.1252-14-digetx@gmail.com> In-Reply-To: <20210926224058.1252-14-digetx@gmail.com> From: Ulf Hansson Date: Fri, 1 Oct 2021 15:39:10 +0200 Message-ID: Subject: Re: [PATCH v13 13/35] drm/tegra: gr2d: Support generic power domain and runtime PM To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Viresh Kumar , Stephen Boyd , Peter De Schrijver , Mikko Perttunen , Peter Chen , Lee Jones , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Nishanth Menon , Adrian Hunter , Michael Turquette , Linux Kernel Mailing List , linux-tegra , Linux PM , Linux USB List , linux-staging@lists.linux.dev, linux-pwm@vger.kernel.org, linux-mmc , dri-devel , DTML , linux-clk , Mark Brown , Vignesh Raghavendra , Richard Weinberger , Miquel Raynal , Lucas Stach , Stefan Agner , Mauro Carvalho Chehab , David Heidelberg Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, 27 Sept 2021 at 00:42, Dmitry Osipenko wrote: > > Add runtime power management and support generic power domains. > > Tested-by: Peter Geis # Ouya T30 > Tested-by: Paul Fertser # PAZ00 T20 > Tested-by: Nicolas Chauvet # PAZ00 T20 and TK1 T124 > Tested-by: Matt Merhar # Ouya T30 > Signed-off-by: Dmitry Osipenko > --- > drivers/gpu/drm/tegra/gr2d.c | 155 +++++++++++++++++++++++++++++++++-- [...] > static int gr2d_remove(struct platform_device *pdev) > @@ -259,15 +312,101 @@ static int gr2d_remove(struct platform_device *pdev) > return err; > } > > + pm_runtime_dont_use_autosuspend(&pdev->dev); > + pm_runtime_disable(&pdev->dev); There is no guarantee that the ->runtime_suspend() has been invoked here, which means that clock may be left prepared/enabled beyond this point. I suggest you call pm_runtime_force_suspend(), instead of pm_runtime_disable(), to make sure that gets done. [...] Kind regards Uffe