From: Jonathan Bell <jonathan@raspberrypi.org>
To: linux-usb@vger.kernel.org
Cc: Minas Harutyunyan <hminas@synopsys.com>
Subject: dwc2 / Raspberry Pi - hardware bug for small transfers results in memory corruption
Date: Wed, 14 Aug 2019 16:59:36 +0100 [thread overview]
Message-ID: <CAPHs_J+G0jR5dMg1gVD0z60Zf4oZBikx6P9+B99-TA6m29DWGA@mail.gmail.com> (raw)
As reported by one of our users here:
https://github.com/raspberrypi/linux/issues/3148
There is a bug when the dwc2 core receives USB data packets that are
between 1 and 4 bytes in length - 4 bytes are always written to memory
where the non-packet bytes are garbage.
This is easily reproducible by
- Plugging a UVC-compliant webcam into a Raspberry Pi gen 1, 2 or 3 product
- Running "v4l2-ctl -d 0 --all"
The camera's control ranges (brightness/contrast etc) are all queried
by 1- or 2-byte control IN transfers. As 4 bytes get written to the
URB's buffer, this results in the uvcvideo data struct containing the
control information getting corrupted like so:
contrast 0x00980901 (int) : min=0 max=64 step=1 default=57343 value=32
saturation 0x00980902 (int) : min=0 max=128 step=1 default=57343 value=105
hue 0x00980903 (int) : min=-40 max=40 step=1 default=-8193 value=0
white_balance_temperature_auto 0x0098090c (bool) : default=1 value=1
gamma 0x00980910 (int) : min=72 max=500 step=1 default=57343 value=100
[etc]
We've implemented a downstream fix for dwc_otg[1] that just forces use
of the dword alignment buffer mechanism (aka DMA bounce buffer), but
dwc2 only uses a bounce buffer for split-IN transfers.
I have two questions:
1) Does this bug occur on non-Pi hardware?
2) What's the easiest way to patch this for dwc2?
[1] https://github.com/raspberrypi/linux/commit/c0e4ca17457d6669a263e86a88f0036875fc019e
next reply other threads:[~2019-08-14 15:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 15:59 Jonathan Bell [this message]
2019-08-15 10:55 ` dwc2 / Raspberry Pi - hardware bug for small transfers results in memory corruption Oliver Neukum
2019-08-15 11:41 ` Jonathan Bell
2019-08-15 14:37 ` Alan Stern
2019-08-15 14:52 ` Oliver Neukum
2019-08-16 22:18 ` Jonathan Bell
2019-08-19 11:01 ` Oliver Neukum
2019-08-15 12:51 ` Lars Melin
2019-08-15 12:54 ` Jonathan Bell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPHs_J+G0jR5dMg1gVD0z60Zf4oZBikx6P9+B99-TA6m29DWGA@mail.gmail.com \
--to=jonathan@raspberrypi.org \
--cc=hminas@synopsys.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).