From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15A0AC4363D for ; Thu, 8 Oct 2020 00:43:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3DD120882 for ; Thu, 8 Oct 2020 00:43:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Wp5sVtYz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727781AbgJHAne (ORCPT ); Wed, 7 Oct 2020 20:43:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726138AbgJHAne (ORCPT ); Wed, 7 Oct 2020 20:43:34 -0400 Received: from mail-vs1-xe44.google.com (mail-vs1-xe44.google.com [IPv6:2607:f8b0:4864:20::e44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D3A4C0613D2 for ; Wed, 7 Oct 2020 17:43:34 -0700 (PDT) Received: by mail-vs1-xe44.google.com with SMTP id 5so2158298vsu.5 for ; Wed, 07 Oct 2020 17:43:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s1vFaQwEYAj+kfpG7wmgAvUX+m94PjPvEEFq0pb+beU=; b=Wp5sVtYz9RFuTf8HwWQcjRqk2whZSdWTSRmHelxkoLivWhEMRrU80IIg0ORfASmxcF Ds2gAwd6GPVZHTi/jSu3NlpIeC4hjGoeQIyn5acmCD0zUs8scF+bGfKwqLd2r3XhPu1M ogURv6eN7z1wFOaBtykUW+a7yfiKds6xXU3Y3C1Ao18Q1zmYxBy6YSU06qV996aDEVBU nzriS/au8lNLN/M3eaZWcLp9AMuLe8B/V4YNR3PGTIEQXYIU0XQrTnB3qmBuAZEzch8D i+qDFMouMGrrxDkWn8dGpbnf8TguzX5KTzBv7yTMa81v5/14Ac4UNNCXox5W8DI/tEMA XEyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s1vFaQwEYAj+kfpG7wmgAvUX+m94PjPvEEFq0pb+beU=; b=Yen9mhK/z5l79t3uWby06fsDRXL7hmWoivirTO5f4i8uCkxio1V4vg+Z1M0fKGKSlY JqHMhWpxKsNf4ZueymrPFs2TvNvduu27qXaHyeslwrxo023MEuc+/cXwzSu/JBw/8lze EeBLGNe+msXjqDA702pzNeO+uIsZ+0BD20NJ3okdW+P4o5kiD/yQ5r4zcHHUU7j9ZOBl 12KqPqpNBlmZBDqaIh230cms/gm5ES8RFQQmbAOA/SD1snHhJVv13CVEbaKkkadBpMBZ bbCTlo70KosupL7W1MGtj3vwKMYQSKm6FnY2FJmIe4J+CaW6SP9/GsNn7N8NHJSfURJA UMUw== X-Gm-Message-State: AOAM5315i04b7gPSjEUNGu5KMAlOLTSHFl8uUcdhdGxz624CPg4NYz2J QsCkNcjZVyYv/EFohLMaJAaC2PQbPm2riixTpAgCpA== X-Google-Smtp-Source: ABdhPJz+HZTLyoGMy4yKKuwstafPHRZcaQ9eu/Qk3P+I6Eahit+EF/pbkIYjvwdX4S62JcdOrVR2+idvgFxLuQUKg40= X-Received: by 2002:a67:ee1a:: with SMTP id f26mr3620209vsp.48.1602117813213; Wed, 07 Oct 2020 17:43:33 -0700 (PDT) MIME-Version: 1.0 References: <20200929024004.244992-1-badhri@google.com> <20200929024004.244992-4-badhri@google.com> <20201005144618.GA154206@bogus> In-Reply-To: <20201005144618.GA154206@bogus> From: Badhri Jagan Sridharan Date: Wed, 7 Oct 2020 17:42:57 -0700 Message-ID: Subject: Re: [PATCH v9 03/15] dt-bindings: usb: Maxim type-c controller device tree binding document To: Rob Herring Cc: Guenter Roeck , Heikki Krogerus , Greg Kroah-Hartman , Lee Jones , Mark Brown , Maxime Ripard , Alexandre Belloni , Thierry Reding , Prashant Malani , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , USB Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi Robb, Thanks for the reviews ! Responses inline. Regards, Badhri On Mon, Oct 5, 2020 at 7:46 AM Rob Herring wrote: > > On Mon, Sep 28, 2020 at 07:39:52PM -0700, Badhri Jagan Sridharan wrote: > > Add device tree binding document for Maxim TCPCI based Type-C chip driver > > > > Signed-off-by: Badhri Jagan Sridharan > > --- > > Changes since v1: > > - Changing patch version to v6 to fix version number confusion. > > > > Changes since v6: > > - Migrated to yaml format. > > > > Changes since v7: > > - Rebase on usb-next > > > > Changes since v8: > > - Fix errors from make dt_binding_check as suggested by > > Rob Herring. > > --- > > .../devicetree/bindings/usb/maxim,tcpci.yaml | 68 +++++++++++++++++++ > > 1 file changed, 68 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/maxim,tcpci.yaml > > > > diff --git a/Documentation/devicetree/bindings/usb/maxim,tcpci.yaml b/Documentation/devicetree/bindings/usb/maxim,tcpci.yaml > > new file mode 100644 > > index 000000000000..f4b5f1a09b98 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/maxim,tcpci.yaml > > @@ -0,0 +1,68 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/usb/maxim,tcpci.yaml#" > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > + > > +title: Maxim TCPCI Type-C PD controller DT bindings > > + > > +maintainers: > > + - Badhri Jagan Sridharan > > + > > +description: Maxim TCPCI Type-C PD controller > > + > > +properties: > > + compatible: > > + enum: > > + - maxim,tcpci > > Is there a datasheet for this? Searching for 'tcpci' doesn't really come > up with anything other than this patch. Only chip I found is MAX77958. > Bindings are for specific h/w devices. Unfortunately the datasheet cannot be made public yet. Has the datasheet have to be made public before sending the bindings ? > > > + > > + interrupts: > > + maxItems: 1 > > + > > + connector: > > + type: object > > + $ref: ../connector/usb-connector.yaml# > > + description: > > + Properties for usb c connector. > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > additionalProperties: false ACK. Adding to the next version of the patch. > > > + > > +examples: > > + - | > > + #include > > + #include > > + i2c0 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + maxtcpc@25 { > > + compatible = "maxim,tcpc"; > > + reg = <0x25>; > > + interrupt-parent = <&gpa8>; > > + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; > > + > > + connector { > > + compatible = "usb-c-connector"; > > + label = "USB-C"; > > + data-role = "dual"; > > + power-role = "dual"; > > + try-power-role = "sink"; > > + self-powered; > > + op-sink-microwatt = <2600000>; > > + source-pdos = > + PDO_FIXED_SUSPEND | > > + PDO_FIXED_USB_COMM | > > + PDO_FIXED_DATA_SWAP | > > + PDO_FIXED_DUAL_ROLE)>; > > + sink-pdos = > + PDO_FIXED_USB_COMM | > > + PDO_FIXED_DATA_SWAP | > > + PDO_FIXED_DUAL_ROLE) > > + PDO_FIXED(9000, 2000, 0)>; > > + }; > > + }; > > + }; > > +... > > -- > > 2.28.0.709.gb0816b6eb0-goog > >