From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4076C433ED for ; Wed, 14 Apr 2021 01:00:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5FA961220 for ; Wed, 14 Apr 2021 01:00:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348918AbhDNBAv (ORCPT ); Tue, 13 Apr 2021 21:00:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348917AbhDNBAs (ORCPT ); Tue, 13 Apr 2021 21:00:48 -0400 Received: from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com [IPv6:2607:f8b0:4864:20::e2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EE16C061574 for ; Tue, 13 Apr 2021 18:00:28 -0700 (PDT) Received: by mail-vs1-xe2d.google.com with SMTP id d25so2894731vsp.1 for ; Tue, 13 Apr 2021 18:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c4u9Tmp7ZH5AX/rlmzOqTLYd8P3KJj0zG0wbcgk2yAg=; b=o2jSaxaynSzILqsenU5eU94XstdDEfcr+8Qslmm/mklm5VuSsLkPrNRYCMhErZuLSI +rib2nSDOqgvO5oB+cXyFVnaY95iSY728Ze0VwRhgpbvJaUIDH0g3ExjNtYJz9M+TtS8 Kke/f4yYgKs1QuJK8QjeYVg9qNv7JC14pbvfHg5ZUSKF9MdarZUcy34CdI2+DrevJcls 0/iyrqvTDT/ZKCGexUDcycfXPZxKitln1l6AgKmDP+aKavq7V5Oe7uGTOv3SY1PZv+T5 Fxi8bBc6IQGq3UMP2hdtaKCfwQ0ETvAKLkuRiM2Dj/umSwJ+F9XXwbFYd0hPt87Bc0CV /rmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c4u9Tmp7ZH5AX/rlmzOqTLYd8P3KJj0zG0wbcgk2yAg=; b=OiopT1B3aY53ggC829kRQIR+JRe0Li5d5P/ITWwC0T5kG/L/uqSDlg7miFLxONQTO2 fWVUpUFVXZxn+8Ci9gmVjRnJMFE0kbbNXhOBV1kQCz9TU4GQipsoODP7KiSxe9s6KNmD 2rSRHCuFMB7VrHdShMTcfHuBAq5c3BpWXqnhXXtD8R61hKv6v5CbhPoF3687+CPL823b MeLpZIONFQ2AFDjq2qzsKqEPrRtKK9vAPzQImzNAQXN+L3WmWWSCArip9qq398qVlbv3 dVoARp4o0cAjmUPzhHlG4WJjkLmHr6C1Zk2ZKLVRZI/2TExuK1K2q79dcJ6BowwOcSra L9Tg== X-Gm-Message-State: AOAM530csJ6aNc7MJZSCJ97BGYQahHPmxkyOZsGJlZPhIwUL6cXInATo DxtY0WjPZuwlMnL+Fuq/tT7iDFdjph5vJqmxdSjdJg== X-Google-Smtp-Source: ABdhPJxx+HyTkPb6szIljEpB1Joai25x8+XQS4HEhkQ3iuldNfeqR0oKtzhrObVZzzYf5l3UpP0abhVEAxAZ0RjTK9s= X-Received: by 2002:a67:2d14:: with SMTP id t20mr23340021vst.48.1618362027253; Tue, 13 Apr 2021 18:00:27 -0700 (PDT) MIME-Version: 1.0 References: <20210407200723.1914388-1-badhri@google.com> <20210407200723.1914388-5-badhri@google.com> In-Reply-To: From: Badhri Jagan Sridharan Date: Tue, 13 Apr 2021 17:59:52 -0700 Message-ID: Subject: Re: [PATCH v2 5/6] usb: typec: tcpm: Allow slow charging loops to comply to pSnkStby To: Heikki Krogerus Cc: Guenter Roeck , Greg Kroah-Hartman , Rob Herring , Adam Thomson , USB , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Kyle Tso Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Thu, Apr 8, 2021 at 1:22 AM Heikki Krogerus wrote: > > > > @@ -4047,9 +4053,12 @@ static void run_state_machine(struct tcpm_port *port) > > > break; > > > case SNK_DISCOVERY: > > > if (port->vbus_present) { > > > - tcpm_set_current_limit(port, > > > - tcpm_get_current_limit(port), > > > - 5000); > > > + u32 current_lim = (!port->slow_charger_loop || > > > + (tcpm_get_current_limit(port) <= > > > + PD_P_SNK_STDBY_MW / 5)) ? > > > + tcpm_get_current_limit(port) : > > > + PD_P_SNK_STDBY_MW / 5; > > > > Here the use of the ternary operator is not appropriate. Please try to > > clean that up somehow. Maybe something like this would be better? > > > > u32 current_lim = tcpm_get_current_limit(port); > > > > if (port->slow_charger_loop || (current_lim < PD_P_SNK_STDBY_MW / 5)) > > current_lim = PD_P_SNK_STDBY_MW / 5; > > Sorry, I mean: > > if (port->slow_charger_loop || (current_lim > PD_P_SNK_STDBY_MW / 5)) > current_lim = PD_P_SNK_STDBY_MW / 5; Ack. Updating in my next version: V3. Thanks, Badhri > > thanks, > > -- > heikki