From: Pawel Laszczak <pawell@cadence.com>
To: "peter.chen@nxp.com" <peter.chen@nxp.com>
Cc: "balbi@kernel.org" <balbi@kernel.org>,
"rogerq@ti.com" <rogerq@ti.com>,
"nsekhar@ti.com" <nsekhar@ti.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rahul Kumar <kurahul@cadence.com>
Subject: RE: [PATCH v3] usb: cdns3: Variable 'length' set but not used
Date: Mon, 26 Oct 2020 09:47:36 +0000 [thread overview]
Message-ID: <DM6PR07MB55290EA090C418457C1E293BDD190@DM6PR07MB5529.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20201015045529.2022-1-pawell@cadence.com>
Hi Peter,
A gentle ping.
I assume that you should add this and the rest overdue cdsn3 patches as first to you ci-for-usb-next branch.
Am I right?
Pawel
>Patch removes not used variable 'length' from
>cdns3_wa2_descmiss_copy_data function.
>
>Fixes: 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")
>Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>Acked-by: Roger Quadros <rogerq@ti.com>
>---
>Changelog:
>v3
>- added "Acked-by" tag.
>v2
>- added "Fixes" tag.
>
> drivers/usb/cdns3/gadget.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
>index 6e7b70a2e352..692acf7b9b14 100644
>--- a/drivers/usb/cdns3/gadget.c
>+++ b/drivers/usb/cdns3/gadget.c
>@@ -506,7 +506,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,
>
> while (!list_empty(&priv_ep->wa2_descmiss_req_list)) {
> int chunk_end;
>- int length;
>
> descmiss_priv_req =
> cdns3_next_priv_request(&priv_ep->wa2_descmiss_req_list);
>@@ -517,7 +516,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,
> break;
>
> chunk_end = descmiss_priv_req->flags & REQUEST_INTERNAL_CH;
>- length = request->actual + descmiss_req->actual;
> request->status = descmiss_req->status;
> __cdns3_descmiss_copy_data(request, descmiss_req);
> list_del_init(&descmiss_priv_req->list);
>--
>2.17.1
next prev parent reply other threads:[~2020-10-26 10:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 4:55 [PATCH v3] usb: cdns3: Variable 'length' set but not used Pawel Laszczak
2020-10-26 9:47 ` Pawel Laszczak [this message]
2020-10-26 11:55 ` Peter Chen
2020-10-27 3:58 ` Peter Chen
2020-10-27 12:08 ` Pawel Laszczak
2020-10-28 6:44 ` Peter Chen
2020-10-28 7:20 ` Pawel Laszczak
2020-10-28 7:35 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR07MB55290EA090C418457C1E293BDD190@DM6PR07MB5529.namprd07.prod.outlook.com \
--to=pawell@cadence.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=peter.chen@nxp.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).