From: OKAMOTO Yoshiaki <yokamoto@allied-telesis.co.jp>
To: Lars Melin <larsm17@gmail.com>, "johan@kernel.org" <johan@kernel.org>
Cc: YAMAMOTO Hiroyuki <hyamamo@allied-telesis.co.jp>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH v2] USB: serial: option: Add support for ZTE MF871A
Date: Sat, 20 Jul 2019 13:20:18 +0000 [thread overview]
Message-ID: <OSAPR01MB3969F5D8E3632CE73EB699F9BCCA0@OSAPR01MB3969.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <1dde5abb-2399-6bb7-531b-c88e5f0b4fae@gmail.com>
Hi Lars,
> Yes, USB_DEVICE_AND_INTERFACE_INFO is the one to use when all the
> interfaces you add support for has identical class/subclass/protocol
> attributes.
>
OK. I will change it to USB_DEVICE_AND_INTERFACE_INFO, and resend patch.
Regards,
Yoshiaki Okamoto
________________________________________
From: Lars Melin <larsm17@gmail.com>
Sent: Friday, July 19, 2019 13:09
To: OKAMOTO Yoshiaki; johan@kernel.org
Cc: YAMAMOTO Hiroyuki; linux-usb@vger.kernel.org
Subject: Re: [PATCH v2] USB: serial: option: Add support for ZTE MF871A
On 7/18/2019 21:46, OKAMOTO Yoshiaki wrote:
>
> Hi Lars,
>
>> Please do a full test of the interface attributes (Class/SubClass/Proto)
>> whenever possible, this could be helpful in case the mfgr makes a device
>> with different interface layout but re-uses an already used vid:pid.
>>
> What should we do specifically for "a full test of the interface attributes"?
>
>
>> Both interfaces has attributes ff/00/00 so there is no reason for doing a less accurate test.
>>
> Forgive me if I’m wrong, did you say mean that we should use USB_DEVICE_AND_INTERFACE_INFO" instead of "USB_DEVICE_INTERFACE_CLASS" ?
>
> Regards,
> Yoshiaki Okamoto
>
Yes, USB_DEVICE_AND_INTERFACE_INFO is the one to use when all the
interfaces you add support for has identical class/subclass/protocol
attributes.
rgds
/Lars
next prev parent reply other threads:[~2019-07-20 13:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 6:53 [PATCH] USB: serial: option: Add support for ZTE MF871A Yoshiaki Okamoto
2019-07-16 9:05 ` Johan Hovold
2019-07-17 5:31 ` OKAMOTO Yoshiaki
2019-07-17 5:40 ` [PATCH v2] " Yoshiaki Okamoto
2019-07-17 6:21 ` Johan Hovold
2019-07-17 12:05 ` Lars Melin
2019-07-18 14:46 ` OKAMOTO Yoshiaki
2019-07-19 4:09 ` Lars Melin
2019-07-20 13:20 ` OKAMOTO Yoshiaki [this message]
2019-07-20 13:23 ` [PATCH v3] " Yoshiaki Okamoto
2019-08-05 11:27 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSAPR01MB3969F5D8E3632CE73EB699F9BCCA0@OSAPR01MB3969.jpnprd01.prod.outlook.com \
--to=yokamoto@allied-telesis.co.jp \
--cc=hyamamo@allied-telesis.co.jp \
--cc=johan@kernel.org \
--cc=larsm17@gmail.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).