From: Biju Das <biju.das@bp.renesas.com>
To: Mao Wenan <maowenan@huawei.com>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>, Hulk Robot <hulkci@huawei.com>
Subject: RE: [PATCH -next] usb: typec: add dependency for TYPEC_HD3SS3220
Date: Wed, 9 Oct 2019 08:00:22 +0000 [thread overview]
Message-ID: <OSBPR01MB21038DCAFE45CE0FFC06EE91B8950@OSBPR01MB2103.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20191009014707.38716-1-maowenan@huawei.com>
Hello Mao Wenan,
Thanks for the patch.
> Subject: [PATCH -next] usb: typec: add dependency for TYPEC_HD3SS3220
>
> If CONFIG_TYPEC_HD3SS3220=y, CONFIG_USB_ROLE_SWITCH=m, below
> errors can be found:
> drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_remove':
> hd3ss3220.c:(.text+0x64): undefined reference to `usb_role_switch_put'
> drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_dr_set':
> hd3ss3220.c:(.text+0x154): undefined reference to
> `usb_role_switch_set_role'
> drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_set_role':
> hd3ss3220.c:(.text+0x294): undefined reference to
> `usb_role_switch_set_role'
> hd3ss3220.c:(.text+0x2f4): undefined reference to
> `usb_role_switch_set_role'
> hd3ss3220.c:(.text+0x348): undefined reference to
> `usb_role_switch_set_role'
> hd3ss3220.c:(.text+0x390): undefined reference to
> `usb_role_switch_set_role'
> drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_probe':
> hd3ss3220.c:(.text+0x5e8): undefined reference to
> `fwnode_usb_role_switch_get'
> hd3ss3220.c:(.text+0x8a4): undefined reference to `usb_role_switch_put'
> make: *** [vmlinux] Error 1
>
> This patch add dependency USB_ROLE_SWITCH for TYPEC_HD3SS3220.
>
> Fixes: 1c48c759ef4b ("usb: typec: driver for TI HD3SS3220 USB Type-C DRP
> port controller")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
Regards,
Biju
> ---
> drivers/usb/typec/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig index
> aceb2af..b4f2aac 100644
> --- a/drivers/usb/typec/Kconfig
> +++ b/drivers/usb/typec/Kconfig
> @@ -53,6 +53,7 @@ source "drivers/usb/typec/ucsi/Kconfig"
> config TYPEC_HD3SS3220
> tristate "TI HD3SS3220 Type-C DRP Port controller driver"
> depends on I2C
> + depends on USB_ROLE_SWITCH
> help
> Say Y or M here if your system has TI HD3SS3220 Type-C DRP Port
> controller driver.
> --
> 2.7.4
next prev parent reply other threads:[~2019-10-09 8:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 1:47 [PATCH -next] usb: typec: add dependency for TYPEC_HD3SS3220 Mao Wenan
2019-10-09 8:00 ` Biju Das [this message]
2019-10-09 8:22 ` Heikki Krogerus
2019-10-16 0:54 ` maowenan
2019-10-16 6:39 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSBPR01MB21038DCAFE45CE0FFC06EE91B8950@OSBPR01MB2103.jpnprd01.prod.outlook.com \
--to=biju.das@bp.renesas.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maowenan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).