From: Alan Stern <stern@rowland.harvard.edu>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Jiri Kosina <jikos@kernel.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Hillf Danton <hdanton@sina.com>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
<linux-input@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] HID: USB: Fix general protection fault caused by Logitech driver
Date: Thu, 22 Aug 2019 16:21:15 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1908221619370.1311-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <CAAeHK+yt=YMvEpvuj2KfA4vnN=ZRFesRCEQJ6450M5JYmFWuDA@mail.gmail.com>
On Thu, 22 Aug 2019, Andrey Konovalov wrote:
> On Thu, Aug 22, 2019 at 7:11 PM Alan Stern <stern@rowland.harvard.edu> wrote:
> >
> > On Thu, 22 Aug 2019, Andrey Konovalov wrote:
> >
> > > Hi Alan,
> > >
> > > I've ran the fuzzer with your patches applied overnight and noticed
> > > another fallout of similar bugs. I think they are caused by a similar
> > > issue in the sony HID driver. There's no hid_hw_stop() call in the "if
> > > (!(hdev->claimed & HID_CLAIMED_INPUT))" case in sony_probe(). Does it
> > > look like a bug to you?
> >
> > It looks like the relevant hid_hw_stop() call is the one at the end of
> > sony_configure_input(). But I can't tell if doing that way is valid or
> > not -- in practice the code would end up calling hid_disconnect() while
> > hid_connect() was still running, which doesn't seem like a good idea.
> >
> > There's a comment about this near the end of sony_probe(). I suspect
> > it would be better to call hid_hw_stop() in the conditional code
> > following that comment rather than in sony_configure_input().
> >
> > Either way, these are all things Jiri should know about or check up on.
> >
> > Have you gotten any test results from syzbot exercising these pathways?
> > You ought to be able to tell which HID driver is involved by looking
> > through the console output.
>
> Yes, a typical crash is below, that's why I thought it's the sony
> driver. Adding hid_hw_stop() in sony_probe() stops the issue from
> happening, but I don't know whether it's the right fix.
Probably you have to add hid_hw_stop() in sony_probe() and remove it
from sony_configure_input(). But like I said above, Jiri should look
into this.
Alan Stern
next prev parent reply other threads:[~2019-08-22 20:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 11:48 WARNING in usbhid_raw_request/usb_submit_urb syzbot
2019-07-30 14:10 ` Alan Stern
2019-07-30 14:12 ` Andrey Konovalov
2019-07-30 14:24 ` Oliver Neukum
2019-07-30 16:58 ` syzbot
2019-08-12 12:46 ` Andrey Konovalov
2019-08-12 13:03 ` syzbot
2019-08-12 14:23 ` Andrey Konovalov
2019-08-13 20:13 ` Alan Stern
2019-08-21 12:51 ` Andrey Konovalov
2019-08-21 13:09 ` syzbot
2019-08-21 14:08 ` Andrey Konovalov
[not found] ` <20190812144720.1980-1-hdanton@sina.com>
2019-08-12 14:55 ` Andrey Konovalov
2019-08-12 15:06 ` general protection fault in __pm_runtime_resume syzbot
2019-08-15 17:43 ` Alan Stern
2019-08-20 20:00 ` [PATCH] HID: USB: Fix general protection fault caused by Logitech driver Alan Stern
2019-08-21 14:11 ` Andrey Konovalov
2019-08-22 7:53 ` Jiri Kosina
2019-08-22 12:32 ` Andrey Konovalov
2019-08-22 17:11 ` Alan Stern
2019-08-22 18:25 ` Andrey Konovalov
2019-08-22 20:21 ` Alan Stern [this message]
2019-08-23 9:29 ` Jiri Kosina
2019-08-24 0:41 ` Roderick.Colenbrander
2019-09-03 10:46 ` Andrey Konovalov
2019-09-03 20:00 ` Roderick.Colenbrander
[not found] ` <20190813042649.888-1-hdanton@sina.com>
2019-08-13 7:35 ` WARNING in usbhid_raw_request/usb_submit_urb Dmitry Vyukov
2019-08-13 8:14 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1908221619370.1311-100000@iolanthe.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=andreyknvl@google.com \
--cc=gustavo@embeddedor.com \
--cc=hdanton@sina.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).