From: Alan Stern <stern@rowland.harvard.edu>
To: Bastien Nocera <hadess@hadess.net>
Cc: linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: Re: [PATCH 4/5] USB: Select better matching USB drivers when available
Date: Thu, 10 Oct 2019 10:19:15 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1910101017260.1581-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <ae7c3e3abfce7cc6d69e8453c3964245db160143.camel@hadess.net>
On Thu, 10 Oct 2019, Bastien Nocera wrote:
> On Wed, 2019-10-09 at 14:45 -0400, Alan Stern wrote:
> >
> On Wed, 9 Oct 2019, Bastien Nocera wrote:
> >
> > <snip>
> > > + return
> > device_driver_attach(usb_generic_driver.drvwrap.driver, dev);
> > > + return error;
> >
> > I think that's right. A little testing wouldn't hurt.
>
> device_driver_attach() isn't available to this part of the code.
>
> I think the only way to do things here might be to set status bit for
> the usb_device and launch device_reprobe(). The second time around, we
> wouldn't match or probe the specific driver.
That would mean probing generic_driver twice, right? You probably
should call its disconnect routine in between.
That sounds pretty awkward, but if there's no other way then go ahead
and do it.
Ala Stern
next prev parent reply other threads:[~2019-10-10 14:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 13:43 [PATCH 0/5] Add Apple MFi fastcharge USB device driver Bastien Nocera
2019-10-09 13:43 ` [PATCH 1/5] USB: Export generic USB device driver functions Bastien Nocera
2019-10-09 13:43 ` [PATCH 2/5] USB: Make it possible to "subclass" usb_device_driver Bastien Nocera
2019-10-09 14:34 ` Alan Stern
2019-10-09 14:41 ` Alan Stern
2019-10-10 8:10 ` Bastien Nocera
2019-10-10 9:58 ` kbuild test robot
2019-10-09 13:43 ` [PATCH 3/5] USB: Implement usb_device_match_id() Bastien Nocera
2019-10-09 14:36 ` Alan Stern
2019-10-09 15:40 ` Bastien Nocera
2019-10-09 17:29 ` Alan Stern
2019-10-09 13:43 ` [PATCH 4/5] USB: Select better matching USB drivers when available Bastien Nocera
2019-10-09 14:43 ` Alan Stern
2019-10-09 15:35 ` Bastien Nocera
2019-10-09 17:28 ` Alan Stern
2019-10-09 18:24 ` Bastien Nocera
2019-10-09 18:45 ` Alan Stern
2019-10-10 8:26 ` Bastien Nocera
2019-10-10 14:19 ` Alan Stern [this message]
2019-10-10 10:33 ` kbuild test robot
2019-10-09 13:43 ` [PATCH 5/5] USB: Add driver to control USB fast charge for iOS devices Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1910101017260.1581-100000@iolanthe.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=benjamin.tissoires@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).