From: Alan Stern <stern@rowland.harvard.edu>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: USB list <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>, Felipe Balbi <balbi@kernel.org>,
Dmitry Vyukov <dvyukov@google.com>,
Alexander Potapenko <glider@google.com>,
Marco Elver <elver@google.com>
Subject: Re: [PATCH 0/1] usb: gadget: add raw-gadget interface
Date: Thu, 14 Nov 2019 10:56:07 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1911141053490.1622-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <CAAeHK+zPh1zkALKNgnJb0_rGWYfTJGU2H+fsbe5XkSD9HLWumA@mail.gmail.com>
On Thu, 14 Nov 2019, Andrey Konovalov wrote:
> > > As a general rule, gadget drivers don't go directly in
> > > drivers/usb/gadget. raw.c counts as a legacy driver (because it's not
> > > written to use the composite gadget framework), so it belongs in
> > > drivers/usb/gadget/legacy. That's where the gadgetfs driver lives, for
> > > example.
> >
> > Hi Alan! Sure, I'll move it to legacy/ in v2. Thanks!
>
> Hi Alan,
>
> Should I move CONFIG_USB_RAW_GADGET into legacy/Kconfig as well? AFAIU
> this makes it impossible to turn on e.g. both GadgetFS and Raw Gadget
> at the same time, since they both become options of the same choice.
We can probably live with that. Not many people will want to build the
Raw Gadget driver, and even fewer will want it together with gadgetfs.
But if you want to keep the Kconfig option in the higher-level
directory, that's probably okay.
Alan Stern
prev parent reply other threads:[~2019-11-14 15:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 18:26 [PATCH 0/1] usb: gadget: add raw-gadget interface Andrey Konovalov
2019-11-08 18:26 ` [PATCH 1/1] " Andrey Konovalov
2019-11-08 21:17 ` Greg Kroah-Hartman
2019-11-08 22:17 ` Andrey Konovalov
2019-11-14 15:08 ` Andrey Konovalov
2019-11-14 15:33 ` Andrey Konovalov
2019-11-15 3:20 ` Greg Kroah-Hartman
2019-11-15 3:19 ` Greg Kroah-Hartman
2019-11-08 21:45 ` [PATCH 0/1] " Alan Stern
2019-11-08 22:18 ` Andrey Konovalov
2019-11-14 15:10 ` Andrey Konovalov
2019-11-14 15:56 ` Alan Stern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1911141053490.1622-100000@iolanthe.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=andreyknvl@google.com \
--cc=balbi@kernel.org \
--cc=corbet@lwn.net \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).