From: Greg KH <gregkh@linuxfoundation.org>
To: penghao <penghao@uniontech.com>
Cc: johan@kernel.org, jonathan@jdcox.net, tomasz@meresinski.eu,
hdegoede@redhat.com, dlaz@chromium.org,
kai.heng.feng@canonical.com, richard.o.dodd@gmail.com,
kerneldev@karsmulder.nl, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: quirks: Add USB_QUIRK_DISCONNECT_SUSPEND quirk for Lenovo A630Z TIO built-in usb-audio card
Date: Wed, 18 Nov 2020 11:20:07 +0100 [thread overview]
Message-ID: <X7T1V7deGBLk49Ul@kroah.com> (raw)
In-Reply-To: <20201118095343.3401-1-penghao@uniontech.com>
On Wed, Nov 18, 2020 at 05:53:43PM +0800, penghao wrote:
> Add a USB_QUIRK_DISCONNECT_SUSPEND quirk for the Lenovo TIO built-in
> usb-audio. when A630Z going into S3,the system immediately wakeup 7-8
> seconds later by usb-audio disconnect interrupt to avoids the issue.
>
> Seeking a better fix, we've tried a lot of things, including:
> - Check that the device's power/wakeup is disabled
> - Check that remote wakeup is off at the USB level
> - All the quirks in drivers/usb/core/quirks.c
> e.g. USB_QUIRK_RESET_RESUME,
> USB_QUIRK_RESET,
> USB_QUIRK_IGNORE_REMOTE_WAKEUP,
> USB_QUIRK_NO_LPM.
>
> but none of that makes any difference.
>
> There are no errors in the logs showing any suspend/resume-related issues.
> When the system wakes up due to the modem, log-wise it appears to be a
> normal resume.
>
> Introduce a quirk to disable the port during suspend when the modem is
> detected.
>
> Changes since v3
> - Fixed spelling error on appropriate
>
> Changes since v2
> - Add Changes commit format
>
> Changes since v1
> - Change subject form "ALSA" to "USB:"
> - Adjust to appropriate line
>
> Signed-off-by: penghao <penghao@uniontech.com>
> ---
> drivers/usb/core/quirks.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 7c1198f80c23..25f655c2cd28 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -410,6 +410,10 @@ static const struct usb_device_id usb_quirk_list[] = {
> { USB_DEVICE(0x1532, 0x0116), .driver_info =
> USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
>
> + /* Lenovo ThinkCenter A630Z TI024Gen3 usb-audio */
> + { USB_DEVICE(0x17ef, 0xa012), .driver_info =
> + USB_QUIRK_DISCONNECT_SUSPEND },
> +
> /* BUILDWIN Photo Frame */
> { USB_DEVICE(0x1908, 0x1315), .driver_info =
> USB_QUIRK_HONOR_BNUMINTERFACES },
> @@ -430,6 +434,7 @@ static const struct usb_device_id usb_quirk_list[] = {
> USB_QUIRK_DELAY_CTRL_MSG },
>
> /* Corsair Strafe RGB */
> +
You are still leaving this blank line being added to the file, please do
not do that.
next prev parent reply other threads:[~2020-11-18 10:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 9:53 [PATCH] USB: quirks: Add USB_QUIRK_DISCONNECT_SUSPEND quirk for Lenovo A630Z TIO built-in usb-audio card penghao
2020-11-18 10:20 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-11-18 12:30 penghao
2020-11-18 13:08 ` Kai-Heng Feng
2020-11-18 11:06 penghao
2020-11-18 11:25 ` Kai-Heng Feng
2020-11-18 9:26 penghao
2020-11-18 9:34 ` Greg KH
2020-11-18 8:56 penghao
2020-11-18 9:03 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X7T1V7deGBLk49Ul@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dlaz@chromium.org \
--cc=hdegoede@redhat.com \
--cc=johan@kernel.org \
--cc=jonathan@jdcox.net \
--cc=kai.heng.feng@canonical.com \
--cc=kerneldev@karsmulder.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=penghao@uniontech.com \
--cc=richard.o.dodd@gmail.com \
--cc=tomasz@meresinski.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).