From: Johan Hovold <johan@kernel.org>
To: "Wang, Sheng Long" <shenglong.wang.ext@siemens.com>
Cc: Johan Hovold <johan@kernel.org>,
Sheng Long Wang <china_shenglong@163.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lkp@intel.com" <lkp@intel.com>
Subject: Re: [PATCH v6] usb-serial:cp210x: add support to software flow control
Date: Fri, 27 Nov 2020 11:23:49 +0100 [thread overview]
Message-ID: <X8DTtVEzL4X8UJCH@localhost> (raw)
In-Reply-To: <496f2cc77b4d4c3a9b49410ac318b927@siemens.com>
[ Again, please do not top-post. Quoting Greg:
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
]
On Mon, Nov 23, 2020 at 01:11:24AM +0000, Wang, Sheng Long wrote:
> Hi, Johan
>
> Do I add my software flow control patch directly to the branch you
> gave me now ?
> https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/log/?h=cp210x-termios
Yes, please rebase your work on top of that branch. I'll merge it to my
usb-next branch before applying your patch.
> Then, I also need the cp210x_ get_ terminus() add ixoff / iXon handling?
No, if you rebase your work on top of the above branch, you won't have
to deal with cp210x_get_termios() which has now been removed.
Just add support for software flow control to the new
cp210x_set_flow_control() function (and cp210x_termios_change()).
I think you can even drop get_special_chars() and just leave the rest
set as NUL, which appears to be the default.
Johan
prev parent reply other threads:[~2020-11-27 10:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 2:24 [PATCH v6] usb-serial:cp210x: add support to software flow control Sheng Long Wang
2020-11-13 15:27 ` Johan Hovold
2020-11-16 7:56 ` Wang, Sheng Long
2020-11-16 16:38 ` Johan Hovold
2020-11-23 1:11 ` Wang, Sheng Long
2020-11-27 10:23 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8DTtVEzL4X8UJCH@localhost \
--to=johan@kernel.org \
--cc=china_shenglong@163.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=shenglong.wang.ext@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).