From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CAA7C64E7B for ; Mon, 30 Nov 2020 13:55:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41CEB2067D for ; Mon, 30 Nov 2020 13:55:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="oHbrHjTq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727009AbgK3Nyg (ORCPT ); Mon, 30 Nov 2020 08:54:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:34436 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726669AbgK3Nyg (ORCPT ); Mon, 30 Nov 2020 08:54:36 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C92012067D; Mon, 30 Nov 2020 13:53:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1606744435; bh=mzcrewT5KlblZ1Fel9HIaLOCygpQZ1nOoc+X07P1R/s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oHbrHjTqyVRo/UtZ4G7ShB8078NjIHt7qo2G7L9N0CE1cPVzqtK7+DNdY6rHG1OSL itPTLRltXPQB1hTi90KuFQezqUKQVCWc+xbFAuhFyezH55938bJ/+3theBRcRp68GT +ImsW9IwuXTeWQPv0YOYWIo0eoIDEijEPViXWqWM= Date: Mon, 30 Nov 2020 14:53:50 +0100 From: Greg KH To: Hans de Goede Cc: Tom Yan , Alan Stern , Christoph Hellwig , linux-usb , Mathias Nyman , Linux Kernel Mailing List , linux-pci@vger.kernel.org, Lu Baolu Subject: Re: [PATCH 2/2] usb-storage: revert from scsi_add_host_with_dma() to scsi_add_host() Message-ID: References: <09992cec-65e4-2757-aae6-8fb02a42f961@redhat.com> <20201128154849.3193-1-tom.ty89@gmail.com> <20201128154849.3193-2-tom.ty89@gmail.com> <5e62c383-22ea-6df6-5acc-5e9f381d4632@redhat.com> <186eb035-4bc4-ff72-ee41-aeb6d81888e3@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Nov 30, 2020 at 02:36:38PM +0100, Hans de Goede wrote: > Hi, > > On 11/30/20 2:30 PM, Greg KH wrote: > > On Mon, Nov 30, 2020 at 02:23:48PM +0100, Hans de Goede wrote: > >> Hi, > >> > >> On 11/30/20 1:58 PM, Tom Yan wrote: > >>> It's merely a moving of comment moving for/and a no-behavioral-change > >>> adaptation for the reversion.> > >> > >> IMHO the revert of the troublesome commit and the other/new changes really > >> should be 2 separate commits. But I will let Alan and Greg have the final > >> verdict on this. > > > > I would prefer to just revert the commits and not do anything > > different/special here so late in the release cycle. > > > > So, if Alan agrees, I'll be glad to do them on my end, I just need the > > commit ids for them. > > The troublesome commit are (in reverse, so revert, order): > > 5df7ef7d32fe ("uas: bump hw_max_sectors to 2048 blocks for SS or faster drives") > 558033c2828f ("uas: fix sdev->host->dma_dev") > 0154012f8018 ("usb-storage: fix sdev->host->dma_dev") > > Alan, the reason for reverting these is that using scsi_add_host_with_dma() as the > last 2 patches do, with the dmadev argument of that call pointing to the device > for the XHCI controller is causing changes to the DMA settings of the XHCI controller > itself which is causing regressions in 5.10, see this email thread: > > https://lore.kernel.org/linux-usb/fde7e11f-5dfc-8348-c134-a21cb1116285@redhat.com/T/#t Thanks, I'll wait for Alan to respond, but I think just reverting these is the best solution at this point in time. You have tested those reverts, solve this, right? If so, can I get a "Tested-by:"? thanks, greg k-h