From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4F75C2BB40 for ; Wed, 9 Dec 2020 18:55:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A77DE20679 for ; Wed, 9 Dec 2020 18:55:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387469AbgLISy5 (ORCPT ); Wed, 9 Dec 2020 13:54:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730111AbgLISy5 (ORCPT ); Wed, 9 Dec 2020 13:54:57 -0500 Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C853C0613D6 for ; Wed, 9 Dec 2020 10:54:17 -0800 (PST) Received: by mail-io1-xd35.google.com with SMTP id o8so2731099ioh.0 for ; Wed, 09 Dec 2020 10:54:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HO/4CIlSDMRn/j2kbhlPl5ANYi1Y0p8wiY4wFHeijhs=; b=vkB/7AxAIHCYkMbFjdweizeYIbuozLY/FFmaQBLEF9J+rcHZr9JsA4AeS1UnEhsK3P y/674KKGQAB/o1b14SYriyrd4RUQgTUWiW6R3tkNrGrEFEDDdOttnvx6j1H94k4ou6ET jn0j5YqWWPihRBm3E5mmAX7cns+DFnIjvxM9fX3gQ9YzjcCCDHQsfqIYFhaKqgSc81uV /0EX5WTCdHP7nuFKUaCk/oFmzXt8vdbDbgbq9QVHYFjK2po0nsrvfGxrFP2+8VdWDdVd By8uoUDxBYP1r401uIA7vSDC48JcsLhgYvnKQQ2MbSX/D5Ar8ifiQiZ5Pv6XDI9gKIU8 Vhng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HO/4CIlSDMRn/j2kbhlPl5ANYi1Y0p8wiY4wFHeijhs=; b=ZPGoB3zP7wRUmx7h8xLXeZL6ep6OWR+X26R6oX01fpaB8npct8WXcmWSWZDQ2lpok+ zS7nto2IYdqjh+T7YHWNT9kNP73I/XETIcNYI/+XpbHbrFHTmhvjOR5L4kD7aq2mDwMl St6SIzLKc74MnIwKtFU0mNSML4F+ZAQSYgxkskoBXg6rZAnQQnIALPliQQ6IcHwWVJD5 T9+psr+l2KXK3gBK4+c6bmni1uCpNY0pnUYXRt0yC45BpJUoljGuSy3tKgtKEBaWurUu Ln7vPuGLwGLFI4SEytcaeshObnDL8zb4o/LpgOlU4mNnEe2tN/ACwQ4AVsst9SaRVwkd iewQ== X-Gm-Message-State: AOAM533k97rvl+pPmh82xtJGAHYRRj7PEPUbLlFiqB3hr88gxFs6tIZz G58Y0vTssjHjrGG0z+Co3lJUlWNlavjahQ== X-Google-Smtp-Source: ABdhPJxoaRMBV4JPyhS8i4cdDXW4RTlYNBAeQco5RoqPullsntcqPbStr7UxrGEf2+YODFro1mcOww== X-Received: by 2002:a6b:8e92:: with SMTP id q140mr4746785iod.182.1607540056428; Wed, 09 Dec 2020 10:54:16 -0800 (PST) Received: from google.com ([2601:285:8380:9270::33b4]) by smtp.gmail.com with ESMTPSA id p18sm1667411ile.27.2020.12.09.10.54.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Dec 2020 10:54:15 -0800 (PST) Date: Wed, 9 Dec 2020 11:54:13 -0700 From: Ross Zwisler To: Mathias Nyman Cc: Andrzej Pietrasiewicz , "linux-usb@vger.kernel.org" , "kernel@collabora.com" Subject: Re: xhci problem -> general protection fault Message-ID: References: <20201001164352.GA13249@google.com> <69f8cbc3-0ae7-cfb2-2fdd-556ada77381f@linux.intel.com> <20201012215348.GA3324220@google.com> <068b49cd-4afa-7adb-572b-634b1728744d@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <068b49cd-4afa-7adb-572b-634b1728744d@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, Dec 09, 2020 at 03:11:14PM +0200, Mathias Nyman wrote: <> > I was testing with Andrzej's script against a g_zero gadget. > I could trigger many similar issues as those he reported, but not this > dequeue issue you see. > > The rewrite resolved all issues I saw. Script was running without issues > over night. (tested against both USB2 and USB3). > > I haven't tried with two devices simultaneously, I could try that. > > Could you share more details about the system you have, what xhci > controller do you have? Sure. I'm running with the following CPU: Intel(R) Xeon(R) Gold 6154 CPU @ 3.00GHz with 72 virtual cores, if that matters. The full output of "lsusb -vvv" can be found here: https://gist.github.com/rzwisler/8c61f10c7a9642cbc6fffe1daadfa8cc And here is the xhci entry in "lspci -vvv": 00:14.0 USB controller: Intel Corporation C620 Series Chipset Family USB 3.0 xHCI Controller (rev 09) (prog-if 30 [XHCI]) Subsystem: Lenovo C620 Series Chipset Family USB 3.0 xHCI Controller Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr+ Stepping- SERR+ FastB2B- DisINTx+ Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- SERR- Kernel driver in use: xhci_hcd Kernel modules: xhci_pci We've seen this issue on a variety of hardware from Lenovo and HP, so it's not specific to this specific workstation model (Lenovo P920). I repro the issue by running the bulk-cancel program against my "servo" hardware, which is debugging hardware for Chromebooks. As I said, though, I can repro it easily without having a device attached, so I *think* all you need is a device which handles BULK IN commands. I've got 2, and if I run against both my system repros the issue in under a minute, usually. With 1 it takes a little longer but still repros, so I don't think it's an interaction between the two devices. Please let me know if I can provide anything else of value.