From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 338ACC04A95 for ; Sat, 22 Oct 2022 11:22:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230368AbiJVLWx (ORCPT ); Sat, 22 Oct 2022 07:22:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229891AbiJVLWi (ORCPT ); Sat, 22 Oct 2022 07:22:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6926D31363; Sat, 22 Oct 2022 03:52:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2F62260BE9; Sat, 22 Oct 2022 10:52:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16C56C433C1; Sat, 22 Oct 2022 10:52:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666435934; bh=LHcXHiycfeGH4pS60pzEWUHjeot59PdVoCs895HZv6o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ls7hRvIuj1gQJ5ozqagr6o6ev7VC3u7cz3f0S50tw0XDM/DBSwtpi8mkPtLYjA38U 34YmD8QV33+pD69n3JsCx4F87PIfIg4U3DtGRfVzug0sggCw/kEN8hUaj4LrJZsYGV yg/WsKNlPXZG7YalH21/M5QkNAv4gfI+UtqMc1JQ= Date: Sat, 22 Oct 2022 12:52:11 +0200 From: Greg KH To: Florian Fainelli Cc: justinpopo6@gmail.com, alcooperx@gmail.com, balbi@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, justin.chen@broadcom.com Subject: Re: [PATCH] usb: bdc: change state when port disconnected Message-ID: References: <1664997235-18198-1-git-send-email-justinpopo6@gmail.com> <81528485-fa80-55ab-16ce-84de520f5262@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <81528485-fa80-55ab-16ce-84de520f5262@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Oct 17, 2022 at 02:05:42PM -0700, Florian Fainelli wrote: > On 10/10/22 07:58, Florian Fainelli wrote: > > > > > > On 10/8/2022 8:44 AM, Greg KH wrote: > > > On Wed, Oct 05, 2022 at 12:13:55PM -0700, justinpopo6@gmail.com wrote: > > > > From: Justin Chen > > > > > > > > When port is connected and then disconnected, the state stays as > > > > configured. Which is incorrect as the port is no longer configured, > > > > but in a not attached state. > > > > > > > > Signed-off-by: Justin Chen > > > > --- > > > >   drivers/usb/gadget/udc/bdc/bdc_udc.c | 1 + > > > >   1 file changed, 1 insertion(+) > > > > > > What commit id does this fix?  Should it go to older kernels?  If so, > > > how far back? > > > > This would be: > > > > Fixes: efed421a94e6 ("usb: gadget: Add UDC driver for Broadcom USB3.0 > > device controller IP BDC") > > > > that issue was present since the driver was included in Linux with the > > commit above, we did not really consider it to be a serious enough bug, > > but I suppose it would not hurt to affix the said Fixes tag. > > Greg, are you picking up the patch as-is, or do you need Justin to resusbmit > with the Fixes: tag added? Now merged, thanks. greg k-h