From: Greg KH <greg@kroah.com>
To: Prike Liang <Prike.Liang@amd.com>
Cc: linux-usb@vger.kernel.org, mathias.nyman@intel.com,
Shyam-sundar.S-k@amd.com, Alexander.Deucher@amd.com,
Ramakanth.Akkenepalli@amd.com, Jack.Xie@amd.com
Subject: Re: [PATCH v3] usb: pci-quirks: disable D3cold on xhci suspend for s2idle
Date: Sat, 6 Feb 2021 15:05:53 +0100 [thread overview]
Message-ID: <YB6iQTE059WnBiPB@kroah.com> (raw)
In-Reply-To: <1612527609-7053-1-git-send-email-Prike.Liang@amd.com>
On Fri, Feb 05, 2021 at 08:20:09PM +0800, Prike Liang wrote:
> The XHCI is required enter D3hot rather than D3cold for AMD s2idle solution.
> Otherwise, the 'Controller Not Ready' (CNR) bit not being cleared by host
> in resume and eventually result in xhci resume failed in s2idle wakeup period.
I do not understand this, can you perhaps rephrase it differently?
Also, please mention the specific hardware that has this bug in the
commit log, or on the subject line, as the subject line is saying that
this change is needed for all devices, when really only one is broken.
>
> v1 -> v2: drop the XHCI_COMP_MODE_QUIRK quirk and create a new one for handling
> XHCI D3cold.
>
> v2 -> v3: correct the quirk name typo XHCI_AMD_S2IDL_SUPPORT_QUIRK -> XHCI_AMD_S2IDLE_SUPPORT_QUIRK
This goes below the --- line, as the documentation asks for.
thanks,
greg k-h
prev parent reply other threads:[~2021-02-06 14:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 12:20 [PATCH v3] usb: pci-quirks: disable D3cold on xhci suspend for s2idle Prike Liang
2021-02-06 14:05 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YB6iQTE059WnBiPB@kroah.com \
--to=greg@kroah.com \
--cc=Alexander.Deucher@amd.com \
--cc=Jack.Xie@amd.com \
--cc=Prike.Liang@amd.com \
--cc=Ramakanth.Akkenepalli@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).