From: Greg KH <firstname.lastname@example.org>
To: Mathias Nyman <email@example.com>
Cc: Howard Yen <firstname.lastname@example.org>,
Mathias Nyman <email@example.com>,
Subject: Re: [PATCH 0/4] add xhci hooks for USB offload
Date: Thu, 28 Jan 2021 08:41:25 +0100 [thread overview]
Message-ID: <YBJqpbspmXZknX4n@kroah.com> (raw)
On Thu, Jan 28, 2021 at 08:31:14AM +0200, Mathias Nyman wrote:
> On 28.1.2021 5.38, Howard Yen wrote:
> > On Tue, Jan 26, 2021 at 10:19 PM Greg KH <firstname.lastname@example.org> wrote:
> >> On Fri, Jan 22, 2021 at 05:32:58PM +0200, Mathias Nyman wrote:
> >>> Ok, before adding hooks like this I think we need to see how they are used.
> >>> Do you have the rest of the patches that go on top of this series?
> >>> Maybe it could make sense to use overrides for the functions in struct hc_driver
> >>> instead in some cases? There is support for that already.
> >> What overrides could be done for these changes? At first glance that
> >> would seem to require a lot of duplicated code in whatever override
> >> happens to be needed.
> >> thanks,
> >> greg k-h
> > This patch series is all the changes for the offload hooks currently.
> > I thought about this, but if I tried to override the functions in
> > struct hc_driver, that'll need to
> > copy many code to the override function, and it won't follow the
> > latest change in the core
> > xhci driver.
> > - Howard
> Ok, I see.
> The point I'm trying to make is that there is no way for me to know if
> these hooks are the right solution before I see any code using them.
> Is the offloading code ready and public somewhere?
There is offload code published in the last few Samsung phone kernels, I
want to get that ported to these hooks to see if that works properly.
Give me a few days and I'll see if I can get it working, I had a
half-finished port around here somewhere...
prev parent reply other threads:[~2021-01-28 7:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 10:10 [PATCH 0/4] add xhci hooks for USB offload Howard Yen
2021-01-19 10:10 ` [PATCH 1/4] usb: host: " Howard Yen
2021-01-19 10:27 ` Greg KH
2021-01-19 10:10 ` [PATCH 2/4] usb: host: export symbols for xhci hooks usage Howard Yen
2021-01-19 10:10 ` [PATCH 3/4] usb: xhci-plat: add xhci_plat_priv_overwrite Howard Yen
2021-01-19 10:10 ` [PATCH 4/4] dt-bindings: usb: usb-xhci: add USB offload support Howard Yen
2021-01-19 10:22 ` Greg KH
2021-02-09 2:30 ` Rob Herring
2021-01-19 10:25 ` [PATCH 0/4] add xhci hooks for USB offload Greg KH
2021-01-19 12:49 ` Mathias Nyman
2021-01-20 10:04 ` Howard Yen
2021-01-22 15:32 ` Mathias Nyman
2021-01-26 14:19 ` Greg KH
2021-01-28 3:38 ` Howard Yen
2021-01-28 6:31 ` Mathias Nyman
2021-01-28 7:41 ` Greg KH [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).