From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1BF5C433DB for ; Tue, 2 Feb 2021 07:33:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C36564EE2 for ; Tue, 2 Feb 2021 07:33:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229632AbhBBHcu (ORCPT ); Tue, 2 Feb 2021 02:32:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:55574 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbhBBHcu (ORCPT ); Tue, 2 Feb 2021 02:32:50 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id F33C464DDD; Tue, 2 Feb 2021 07:32:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612251129; bh=PEpcMlXbAvVlCef+LCydHc4SZgper6ya9C4OFl1mH14=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lQmHJzckD21+NYrm50hqqA0a5+ataMF5Qq5KGqL3JUZmSUOwVV/5TEc9vjyOt7heg Fb61fQvgJ7QCh8dBcza7Y1VZXc88ilgn+Rp72VzMs8zOlgAvozNA+f71lwwSXUf7yD JjkQRU5U7sxAPWSNPMeAiJxjSdBz7tl6RasVOG88= Date: Tue, 2 Feb 2021 08:32:06 +0100 From: Greg KH To: Benson Leung Cc: Benson Leung , heikki.krogerus@linux.intel.com, enric.balletbo@collabora.com, pmalani@chromium.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, groeck@chromium.org Subject: Re: [PATCH 0/6] usb: typec: and platform/chrome: Add PD revision numbers Message-ID: References: <20210129061406.2680146-1-bleung@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Feb 01, 2021 at 11:04:15PM -0800, Benson Leung wrote: > Hi Greg, > > On Mon, Feb 01, 2021 at 03:32:47PM +0100, Greg KH wrote: > > On Thu, Jan 28, 2021 at 10:14:00PM -0800, Benson Leung wrote: > > > USB Power Delivery has a 3 entity handshake (port, cable, partner), and as > > > of USB PD R3.0, each entity may independently support either Revision 2 or > > > Revision 3 signaling and protocol. In order for userspace and the kernel > > > to properly process the data objects received from a particular SOP*, we > > > must know to which revision of the spec each conforms. > > > > > > This series adds individual version numbers for the partner and the cable, > > > and exposes them in the appropriate sysfs in /sys/class/typec. > > > > > > I provide as a first implementation of this, platform/chrome's cros_ec_typec > > > driver, whose underlying status messages convey the SOP and SOP' revisions > > > already. > > > > I've taken the first 3 patches in my tree now, but the last 3 (for the > > chrome_ec_typec.c driver), they do not apply at all. > > > > Ah, that's because we have some other changes for the cros_ec_typec.c driver > already in platform/chrome for our 5.12 branch. > > For 5.12, the changes for cros_ec_typec driver is pretty well contained, > although there is some dependence on typec subsystem changes now. > > If I send you a pull request containing all of the changes for this driver we > have already merged, plus these last three that depend on both of our trees > would you merge it through usb for 5.12? If the subsystem maintainer says it is ok, yes, I will be glad to take a stable git tag to pull from into my usb-next branch. thanks, greg k-h