From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Felipe Balbi <balbi@kernel.org>,
Mathias Nyman <mathias.nyman@intel.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Minas Harutyunyan <hminas@synopsys.com>
Subject: Re: [PATCH v2 2/6] usb: dwc2: pci: Drop the empty quirk function
Date: Thu, 4 Feb 2021 15:40:05 +0100 [thread overview]
Message-ID: <YBwHRcyjmvPhajGX@kroah.com> (raw)
In-Reply-To: <20210204141711.53775-3-heikki.krogerus@linux.intel.com>
On Thu, Feb 04, 2021 at 05:17:07PM +0300, Heikki Krogerus wrote:
> The function dwc2_pci_quirks() does nothing. Removing.
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: Minas Harutyunyan <hminas@synopsys.com>
> ---
> drivers/usb/dwc2/pci.c | 18 ------------------
> 1 file changed, 18 deletions(-)
>
> diff --git a/drivers/usb/dwc2/pci.c b/drivers/usb/dwc2/pci.c
> index 7afc10872f1f0..0000151e3ca96 100644
> --- a/drivers/usb/dwc2/pci.c
> +++ b/drivers/usb/dwc2/pci.c
> @@ -63,20 +63,6 @@ struct dwc2_pci_glue {
> struct platform_device *phy;
> };
>
> -static int dwc2_pci_quirks(struct pci_dev *pdev, struct platform_device *dwc2)
> -{
> - if (pdev->vendor == PCI_VENDOR_ID_SYNOPSYS &&
> - pdev->device == PCI_PRODUCT_ID_HAPS_HSOTG) {
> - struct property_entry properties[] = {
> - { },
> - };
> -
> - return platform_device_add_properties(dwc2, properties);
> - }
> -
> - return 0;
> -}
> -
> /**
> * dwc2_pci_probe() - Provides the cleanup entry points for the DWC_otg PCI
> * driver
> @@ -143,10 +129,6 @@ static int dwc2_pci_probe(struct pci_dev *pci,
>
> dwc2->dev.parent = dev;
>
> - ret = dwc2_pci_quirks(pci, dwc2);
> - if (ret)
> - goto err;
> -
> glue = devm_kzalloc(dev, sizeof(*glue), GFP_KERNEL);
> if (!glue) {
> ret = -ENOMEM;
This is crazy. I'll go apply this right now :)
thanks,
greg k-h
next prev parent reply other threads:[~2021-02-04 14:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 14:17 [PATCH v2 0/6] usb: Handle device properties with software node API Heikki Krogerus
2021-02-04 14:17 ` [PATCH v2 1/6] software node: Provide replacement for device_add_properties() Heikki Krogerus
2021-02-04 16:06 ` Rafael J. Wysocki
2021-02-04 16:13 ` Greg Kroah-Hartman
2021-02-05 9:08 ` Greg Kroah-Hartman
2021-02-04 14:17 ` [PATCH v2 2/6] usb: dwc2: pci: Drop the empty quirk function Heikki Krogerus
2021-02-04 14:40 ` Greg Kroah-Hartman [this message]
2021-02-04 14:17 ` [PATCH v2 3/6] usb: dwc3: haps: Constify the software node Heikki Krogerus
2021-02-04 14:42 ` Greg Kroah-Hartman
2021-02-04 14:17 ` [PATCH v2 4/6] usb: dwc3: qcom: " Heikki Krogerus
2021-02-04 14:17 ` [PATCH v2 5/6] usb: dwc3: host: Use software node API with the properties Heikki Krogerus
2021-02-04 14:17 ` [PATCH v2 6/6] xhci: ext-caps: " Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBwHRcyjmvPhajGX@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=balbi@kernel.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hminas@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).