From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E9DCC433DB for ; Tue, 9 Feb 2021 12:01:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 385B264EBA for ; Tue, 9 Feb 2021 12:01:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230207AbhBIMBX (ORCPT ); Tue, 9 Feb 2021 07:01:23 -0500 Received: from mail.kernel.org ([198.145.29.99]:52362 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229813AbhBIMAM (ORCPT ); Tue, 9 Feb 2021 07:00:12 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id C6C6364E6F; Tue, 9 Feb 2021 11:59:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612871972; bh=6xtapKw7KSUTnW2dJX6/c2jdOgxA/82XY6L3LG5I8Ew=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zDAsfff7NgEiwnUn3hJ5hk3eXcxBFfBRDbrkiRD1M7guOL3jknRK6/KlJHGScA+dt bq8NZG9qLGNqG1f6HOlMSFezotfU47SUsI8MDM9R6a1RlsFRRHR18iTAL8mlV0c9Bc 3gsizCBzog+cfJBvOqLiRbKYzHWEo3VnKdJV0MYc= Date: Tue, 9 Feb 2021 12:59:29 +0100 From: Greg Kroah-Hartman To: Michal Simek Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com, Paul Cercueil , linux-usb@vger.kernel.org Subject: Re: [PATCH] usb: misc: usb3503: Fix logic in usb3503_init() Message-ID: References: <4ae929dc31c170252154352d04e89c8456d91ca3.1612870239.git.michal.simek@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ae929dc31c170252154352d04e89c8456d91ca3.1612870239.git.michal.simek@xilinx.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Feb 09, 2021 at 12:30:42PM +0100, Michal Simek wrote: > Based on > https://lore.kernel.org/linux-arm-kernel/YCJv59g3Tq2haDSa@kroah.com/ > initialization should fail if any registration fails. > > Signed-off-by: Michal Simek > --- > > drivers/usb/misc/usb3503.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c > index 48099c6bf04c..3aae83fbebae 100644 > --- a/drivers/usb/misc/usb3503.c > +++ b/drivers/usb/misc/usb3503.c > @@ -409,13 +409,17 @@ static int __init usb3503_init(void) > int err; > > err = i2c_add_driver(&usb3503_i2c_driver); > - if (err != 0) > + if (err) { > pr_err("usb3503: Failed to register I2C driver: %d\n", err); > + return err; > + } > > err = platform_driver_register(&usb3503_platform_driver); > - if (err != 0) > + if (err) { > pr_err("usb3503: Failed to register platform driver: %d\n", > err); > + return err; You just left a i2c driver registered :(