From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7842EC433DB for ; Fri, 12 Feb 2021 18:01:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4AD7764E6C for ; Fri, 12 Feb 2021 18:01:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231317AbhBLSBy (ORCPT ); Fri, 12 Feb 2021 13:01:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231348AbhBLSBw (ORCPT ); Fri, 12 Feb 2021 13:01:52 -0500 Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 960C8C0613D6 for ; Fri, 12 Feb 2021 10:01:13 -0800 (PST) Received: by mail-ot1-x329.google.com with SMTP id 100so9179757otg.3 for ; Fri, 12 Feb 2021 10:01:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DgDULeiKflVFwoR6BsGB3cUqPpNxfkBwuzxZxXpXoLY=; b=DCzDEBVjLIaaQd57q6fVH1cUKOsUzde77Y6qiR5L/k48zTlVtQYI7DtAlnEuHF9q0X 57rDgE3EcctbG+Jjyd+60Xa5CgCSRK1FuwvPs9VyBfXVKDLM67rJPYdyWPy19b9xMWBO QSR459ll+V93R4uNHr4h0eO5o3QUfjngs5f5dPrkNeivbE3YQCBNlmQAy1dDZosVX3EL 6D1Xz5zusS+1ld+MGkk3JmZ2ySbbSANFUOOXxCVgZq+JEZ3YP9okvyOPuFhS+4Oe7XD6 56tb6NsTZPbt4iLyids3gREv+ebIoulLV0KlupwbKepL8afknT8QgtgpkI/JAdCsWg9C fOBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DgDULeiKflVFwoR6BsGB3cUqPpNxfkBwuzxZxXpXoLY=; b=avz8ch6W3mClNdBxTcDx/eeKsBwil053RHBoemuYM5GY1cW2VLqqelaZgf58jxMwgO N9tZ9sYvdhViZ4vyZcuNzjXO/gpVVmsUV5CzRrtdRzdv1Q6HGs/u8K03BSJ3Z56bulzt G2J/QSFkBd/IzZMGouoxmRalxMLtzspKW4Go2XERG2E+PFnimktp53bXlvbEi8pem2x/ jvuLrJatY3el3PuUQq9OvdPO+MHohvSQy/ZXfoEqBy9rddw8tWM4gph8+9rSCsb0H7nX 2feCMtbC3KXGNLtIohG6Fja1nVnf6c4rnG9eJPUwtEwt337Fo8iUTMRp+mbQlLKwksTX bB5w== X-Gm-Message-State: AOAM530ombF3/xqz93TdkeHUapjGcvOjKZCuGRXKfEymSkS2ND6OE5p2 RmNl25qcxL2/Ir+nOF32PClg4A== X-Google-Smtp-Source: ABdhPJyniCmu8jCeQK56LqSsb0pYBEXvHH0wktvHQXkTlk5uyu8JEP55tx/ozoDyxTZNRcxrBKdOug== X-Received: by 2002:a9d:8f2:: with SMTP id 105mr2836518otf.64.1613152872844; Fri, 12 Feb 2021 10:01:12 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id e14sm1684583oou.19.2021.02.12.10.01.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 10:01:12 -0800 (PST) Date: Fri, 12 Feb 2021 12:01:10 -0600 From: Bjorn Andersson To: Serge Semin Cc: Serge Semin , Rob Herring , Felipe Balbi , Krzysztof Kozlowski , Florian Fainelli , Greg Kroah-Hartman , Andy Gross , Linux USB List , linux-arm-msm , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v6 09/10] usb: dwc3: qcom: Detect DWC3 DT-nodes with "usb"-prefixed names Message-ID: References: <20210210172850.20849-1-Sergey.Semin@baikalelectronics.ru> <20210210172850.20849-10-Sergey.Semin@baikalelectronics.ru> <20210210184051.ncvvs5xgyo7o3uzq@mobilestation> <20210210193325.inp7rgpsfr624zhd@mobilestation> <20210212173315.jgr6kata2yxrbkuu@mobilestation> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210212173315.jgr6kata2yxrbkuu@mobilestation> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri 12 Feb 11:33 CST 2021, Serge Semin wrote: > On Wed, Feb 10, 2021 at 10:33:26PM +0300, Serge Semin wrote: > > On Wed, Feb 10, 2021 at 12:56:59PM -0600, Bjorn Andersson wrote: > > > On Wed 10 Feb 12:40 CST 2021, Serge Semin wrote: > > > > > > > On Wed, Feb 10, 2021 at 12:17:27PM -0600, Rob Herring wrote: > > > > > On Wed, Feb 10, 2021 at 11:29 AM Serge Semin > > > > > wrote: > > > > > > > > > > > > In accordance with the USB HCD/DRD schema all the USB controllers are > > > > > > supposed to have DT-nodes named with prefix "^usb(@.*)?". Since the > > > > > > existing DT-nodes will be renamed in a subsequent patch let's first make > > > > > > sure the DWC3 Qualcomm driver supports them and second falls back to the > > > > > > deprecated naming so not to fail on the legacy DTS-files passed to the > > > > > > newer kernels. > > > > > > > > > > > > Signed-off-by: Serge Semin > > > > > > Reviewed-by: Bjorn Andersson > > > > > > --- > > > > > > drivers/usb/dwc3/dwc3-qcom.c | 3 ++- > > > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > > > > > > index c703d552bbcf..49ad8d507d37 100644 > > > > > > --- a/drivers/usb/dwc3/dwc3-qcom.c > > > > > > +++ b/drivers/usb/dwc3/dwc3-qcom.c > > > > > > @@ -630,7 +630,8 @@ static int dwc3_qcom_of_register_core(struct platform_device *pdev) > > > > > > struct device *dev = &pdev->dev; > > > > > > int ret; > > > > > > > > > > > > - dwc3_np = of_get_child_by_name(np, "dwc3"); > > > > > > + dwc3_np = of_get_child_by_name(np, "usb") ?: > > > > > > + of_get_child_by_name(np, "dwc3"); > > > > > > > > > > > > > > Is there some reason using compatible instead wouldn't work here? > > > > > > > > I don't know for sure. The fix has been requested in the framework of > > > > this discussion: > > > > https://lore.kernel.org/linux-usb/20201020115959.2658-30-Sergey.Semin@baikalelectronics.ru/#t > > > > by the driver maintainer Bjorn. To get a firm answer it's better to > > > > have him asked. > > > > > > My feedback was simply that it has to catch both cases, I didn't > > > consider the fact that we have a compatible to match against. > > > > > > > As I see it having of_get_compatible_child() utilized > > > > here would also work. At least for the available in kernel dt-files. > > > > See the affected dts-es in: > > > > https://lore.kernel.org/linux-usb/20210210172850.20849-11-Sergey.Semin@baikalelectronics.ru/ > > > > > > > > A problem may happen if some older versions of DTS-es had another > > > > compatible string in the dwc3 sub-node... > > > > > > > > > > Afaict all Qualcomm dts files has "snps,dwc3", so you can match against > > > that instead. > > > > Ok then. I'll replace of_get_child_by_name() here with > > of_get_compatible_child() matching just against "snps,dwc3" in v7. Can you > > confirm that noone ever had a Qcom-based hardware described with dts having > > the "synopsys,dwc3" compatible used as the DWC USB3 sub-node here? That > > string has been marked as deprecated recently because the vendor-prefix > > was changed sometime ago, but the original driver still accept it. > > > > Alternatively to be on a safe side we could match against both > > compatibles here as Rob suggests. What do you think? > > Bjorn, any comment on the question above? So I could respin the series > with this patch updated. > > Also note, since the patch's gonna be changed I'll have to remove your > Reviewed-by tag unless u explicitly say I shouldn't. > Sounds good, I'd be happy to review the new patch. PS. As this only affect the Qualcomm part of the series I would suggest that you send these patches off separate and don't send all 10 patches together. Thanks, Bjorn