linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "tiantao (H)" <tiantao6@huawei.com>
Cc: Tian Tao <tiantao6@hisilicon.com>, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: hcd: remove unused including <linux/version.h>
Date: Wed, 3 Mar 2021 08:31:59 +0100	[thread overview]
Message-ID: <YD87b/zYXgEFmmXl@kroah.com> (raw)
In-Reply-To: <ff94889c-1d51-e6e3-65dc-739b7509e05c@huawei.com>

On Wed, Mar 03, 2021 at 03:15:53PM +0800, tiantao (H) wrote:
> 
> 在 2021/3/3 15:02, Greg KH 写道:
> > On Wed, Mar 03, 2021 at 09:09:12AM +0800, Tian Tao wrote:
> > > Remove including <linux/version.h> that don't need it.
> > > 
> > > Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> > > ---
> > >   drivers/usb/core/hcd.c | 1 -
> > >   1 file changed, 1 deletion(-)
> > > 
> > > diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> > > index 3f03813..53bc93d 100644
> > > --- a/drivers/usb/core/hcd.c
> > > +++ b/drivers/usb/core/hcd.c
> > > @@ -11,7 +11,6 @@
> > >   #include <linux/bcd.h>
> > >   #include <linux/module.h>
> > > -#include <linux/version.h>
> > >   #include <linux/kernel.h>
> > >   #include <linux/sched/task_stack.h>
> > >   #include <linux/slab.h>
> > You obviously did not even test-build this patch, which is very odd when
> > submitting something to the community.  Why did you not do this?
> > 
> > This file _DOES_ need this .h file, whatever tool you are using to
> > detect this is completely broken.  Please fix it and be more careful
> > before sending new patches.
> this is reported by command “make versioncheck”

Then the tool is broken.  Why did you not test-build your change before
sending it?  Did you read the checklist of "what to do before sending a
patch" that we have in our documentation?  If not, please do so.

thanks,

greg k-h

      reply	other threads:[~2021-03-03 11:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03  1:09 [PATCH] usb: hcd: remove unused including <linux/version.h> Tian Tao
2021-03-03  7:02 ` Greg KH
2021-03-03  7:15   ` tiantao (H)
2021-03-03  7:31     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YD87b/zYXgEFmmXl@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=tiantao6@hisilicon.com \
    --cc=tiantao6@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).