linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dominique MARTINET <dominique.martinet@atmark-techno.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sakari Ailus <sakari.ailus@iki.fi>,
	linux-uvc-devel@lists.sourceforge.net, linux-usb@vger.kernel.org,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v3 0/5] media: uvcvideo: Fix race conditions
Date: Fri, 12 Mar 2021 16:36:14 +0900	[thread overview]
Message-ID: <YEsZ7qnSRv0EkJGG@atmark-techno.com> (raw)
In-Reply-To: <990652f1-b6e4-211c-7a96-8c3fc3ea6efd@roeck-us.net>

Hi,

Guenter Roeck wrote on Thu, Sep 17, 2020 at 07:16:17PM -0700:
> On 9/17/20 5:47 AM, Laurent Pinchart wrote:
> > On Wed, Sep 16, 2020 at 07:25:42PM -0700, Guenter Roeck wrote:
> >> Something seems to have gone wrong with v3 of this patch series.
> >> I am sure I sent it out, but I don't find it anywhere.
> >> Resending. Sorry for any duplicates.
> > 
> > I haven't checked the mailing list, but I've found it in my inbox :-)
> > I'm not forgetting about you, just been fairly busy recently. I still
> > plan to try and provide an alternative implementation in the V4L2 core
> > (in a form that I think should even be moved to the cdev core) that
> > would fix this for all drivers.
> > 
> Thanks for letting me know. As it turns out, this problem is responsible
> for about 2% of all Chromebook crashes, so I'll probably not wait for
> the series to be accepted upstream but apply it as-is to the various
> ChromeOS kernel branches.

We have a customer who reported the same issue recently, has there been
any development?

I don't see anything in either uvc nor v4l2 that would address the race
since this mail half a year ago (well, I could have missed it ;))


If nothing happened I'll probably backport this series as well, at which
point it might make more sense to take it in until a better fix gets
here then revert it...


Thanks!
-- 
Dominique

  reply	other threads:[~2021-03-12  7:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17  2:25 [PATCH RESEND v3 0/5] media: uvcvideo: Fix race conditions Guenter Roeck
2020-09-17  2:25 ` [PATCH RESEND v3 1/5] media: uvcvideo: Cancel async worker earlier Guenter Roeck
2021-06-17 17:06   ` Ezequiel Garcia
2020-09-17  2:25 ` [PATCH RESEND v3 2/5] media: uvcvideo: Lock video streams and queues while unregistering Guenter Roeck
2020-09-17  2:25 ` [PATCH RESEND v3 3/5] media: uvcvideo: Release stream queue when unregistering video device Guenter Roeck
2020-09-17  2:25 ` [PATCH RESEND v3 4/5] media: uvcvideo: Protect uvc queue file operations against disconnect Guenter Roeck
2020-09-17  2:25 ` [PATCH RESEND v3 5/5] media: uvcvideo: Abort uvc_v4l2_open if video device is unregistered Guenter Roeck
2020-09-17 12:47 ` [PATCH RESEND v3 0/5] media: uvcvideo: Fix race conditions Laurent Pinchart
2020-09-18  2:16   ` Guenter Roeck
2021-03-12  7:36     ` Dominique MARTINET [this message]
2021-03-12 14:54       ` Guenter Roeck
2021-06-09  4:12         ` Dominique MARTINET
2022-03-11 20:24 ` Michael Grzeschik
2022-03-12 18:43   ` Laurent Pinchart
2022-08-23  8:37     ` Lukasz Majczak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YEsZ7qnSRv0EkJGG@atmark-techno.com \
    --to=dominique.martinet@atmark-techno.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux-uvc-devel@lists.sourceforge.net \
    --cc=linux@roeck-us.net \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).