From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6848EC433B4 for ; Thu, 8 Apr 2021 22:49:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32DD76115B for ; Thu, 8 Apr 2021 22:49:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232804AbhDHWti (ORCPT ); Thu, 8 Apr 2021 18:49:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232643AbhDHWth (ORCPT ); Thu, 8 Apr 2021 18:49:37 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B65B1C061760 for ; Thu, 8 Apr 2021 15:49:23 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id s11so2942342pfm.1 for ; Thu, 08 Apr 2021 15:49:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OA781OccRNwXE7rt2K4lFZ5YBX2tVVTL8OP2VVE7W5k=; b=WV51htl117L8zuAaqHXXoY7ed5xTWBqk5ntWuoyogOc/YvHhI2fi3POHYHV+gyiI+h 7jwQJ5n3UeNi0UQ+xcGrHwjZQTU4J95PvkA1frsL8un4AnJ2cNbmyci9oGBSQX11Nx04 lLiHi1bh92wdh08yNIMHySzMNYC96WXXNunv8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OA781OccRNwXE7rt2K4lFZ5YBX2tVVTL8OP2VVE7W5k=; b=d2FtPm71duYsuzm+x8rQ2Fsk1zQGDoNOosNG0UGMKMFtjKeqCMAVBpUI4zg1ep1g7X QBrXDV3prDcO1KfbANJurc5OVa7GeepJlVKoDwgLtuhwawEzPrIDNgRPzjPRHqGEn0IN Q6JC65sCBj+7w7vsH3X3jTY7dXyW8RCILBP0jTU4MhfqFbH7vxuxW1KUSmkYN02Rh75C LmgQ2ihglFM0Urz5LhibBs9EBNS/ED2L9r/t1W8AGN+oYuZQicKwv8S2PiPZFDY8kvvA 0f9thvLnGfY9KsklVv39fdE6EKJVOph8HA7SapFsQ9YyoVH7ANPjCsKr54Vghcj/a/gj zBPQ== X-Gm-Message-State: AOAM531YJL86oHQ7eYQf0YeaCd1NV5zM84qj6QRW2YeTlQgACoZuyD78 9299+cK/N4YrwS30yr+WjfHr7g== X-Google-Smtp-Source: ABdhPJzBrRR/poki5sG+OHaXYR11z6gwhKEfjfuEHH4IEwICWTvaml5hGOyodyjI9brEWQS0oONOvQ== X-Received: by 2002:a05:6a00:2389:b029:21a:d3b4:e5 with SMTP id f9-20020a056a002389b029021ad3b400e5mr9858217pfc.39.1617922163264; Thu, 08 Apr 2021 15:49:23 -0700 (PDT) Received: from localhost ([2620:15c:202:201:d013:d350:4066:89b8]) by smtp.gmail.com with UTF8SMTPSA id d26sm417094pfo.162.2021.04.08.15.49.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Apr 2021 15:49:22 -0700 (PDT) Date: Thu, 8 Apr 2021 15:49:21 -0700 From: Matthias Kaehlcke To: Rob Herring Cc: Greg Kroah-Hartman , Alan Stern , Frank Rowand , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Douglas Anderson , Peter Chen , Michal Simek , linux-usb@vger.kernel.org, Ravi Chandra Sadineni , Bastien Nocera , devicetree@vger.kernel.org, Stephen Boyd Subject: Re: [PATCH v6 1/5] dt-bindings: usb: Add binding for Realtek RTS5411 hub controller Message-ID: References: <20210405201817.3977893-1-mka@chromium.org> <20210405124900.v6.1.I248292623d3d0f6a4f0c5bc58478ca3c0062b49a@changeid> <20210406163001.GA1910748@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210406163001.GA1910748@robh.at.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Apr 06, 2021 at 11:30:01AM -0500, Rob Herring wrote: > On Mon, Apr 05, 2021 at 01:18:13PM -0700, Matthias Kaehlcke wrote: > > The Realtek RTS5411 is a USB 3.0 hub controller with 4 ports. > > > > This initial version of the binding only describes USB related > > aspects of the RTS5411, it does not cover the option of > > connecting the controller as an i2c slave. > > > > Signed-off-by: Matthias Kaehlcke > > --- > > > > Changes in v7: > > - added type ref for 'companion-hub' property > > > > Changes in v6: > > - Realtek binding instead of generic onboard_usb_hub > > - added 'companion-hub' property > > - added reference to 'usb-device.yaml' > > - 'fixed' indentation of compatible entries to keep yamllint happy > > - added 'additionalProperties' entry > > - updated commit message > > > > Changes in v5: > > - updated 'title' > > - only use standard USB compatible strings > > - deleted 'usb_hub' node > > - renamed 'usb_controller' node to 'usb-controller' > > - removed labels from USB nodes > > - added 'vdd-supply' to USB nodes > > > > Changes in v4: > > - none > > > > Changes in v3: > > - updated commit message > > - removed recursive reference to $self > > - adjusted 'compatible' definition to support multiple entries > > - changed USB controller phandle to be a node > > > > Changes in v2: > > - removed 'wakeup-source' and 'power-off-in-suspend' properties > > - consistently use spaces for indentation in example > > > > .../bindings/usb/realtek,rts5411.yaml | 59 +++++++++++++++++++ > > 1 file changed, 59 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/realtek,rts5411.yaml > > > > diff --git a/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml b/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml > > new file mode 100644 > > index 000000000000..b59001972749 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/realtek,rts5411.yaml > > @@ -0,0 +1,59 @@ > > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/usb/realtek,rts5411.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Binding for the Realtek RTS5411 USB 3.0 hub controller > > + > > +maintainers: > > + - Matthias Kaehlcke > > + > > +allOf: > > + - $ref: usb-device.yaml# > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - usbbda,5411 > > + - usbbda,411 > > + > > reg: true > > to fix the error. Will fix in v8 (this is v7, even though the subject says otherwise, I forgot to increment the version number when sending). > > + vdd-supply: > > + description: > > + phandle to the regulator that provides power to the hub. > > + > > + companion-hub: > > + $ref: '/schemas/types.yaml#/definitions/phandle' > > + description: > > + phandle to the companion hub on the controller. > > This should be required I think. I suppose you could only hook up 2.0 > ports, but why. And 3.0 only wouldn't be USB compliant, would it? Agreed, that makes sense now that this is a specific binding for the RTS5411. It seems unlikely that a system would use a USB 3.0 capable hub on a USB 2.0 controller, and as you said 3.0 only wouldn't be USB compliant. I made the attribute initially optional because the binding was intended to be generic (bad idea), and for certain hubs a required 'companion-hub' wouldn't make sense (e.g. USB 2.0 only). > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + usb-controller { > > 'usb' is the standard name. ack Thanks for your comments! m.