From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8115C433B4 for ; Fri, 9 Apr 2021 14:04:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C06F761165 for ; Fri, 9 Apr 2021 14:04:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232796AbhDIOEy (ORCPT ); Fri, 9 Apr 2021 10:04:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:51202 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231127AbhDIOEx (ORCPT ); Fri, 9 Apr 2021 10:04:53 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 67DC661108; Fri, 9 Apr 2021 14:04:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617977080; bh=yKWsA1tj25u0+0VAe93DnnuhYoM2MG0/uON9oz+d1ek=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KJC0AMqmdA9HJIMDjdweckcbxRNXsKOo1LMcc/zJ301JLyy0ZwL94YLCW5r9CIfcG Ek1Tmb/1FiIRyx58I0cl7gzOfvxUyDHe3lm1tsOJNDQy5bsQoyjkR2zIQEu+ka/Pl0 NpRja8RagTBx8oEJDw6a8hnvABP7jKWPV0eTCQm4= Date: Fri, 9 Apr 2021 16:04:38 +0200 From: Greg KH To: Ye Bin Cc: valentina.manea.m@gmail.com, shuah@kernel.org, linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org, hulkci@huawei.com Subject: Re: [PATCH -next v2] usbip: vudc: fix missing unlock on error in usbip_sockfd_store() Message-ID: References: <20210408112305.1022247-1-yebin10@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210408112305.1022247-1-yebin10@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Thu, Apr 08, 2021 at 07:23:05PM +0800, Ye Bin wrote: > Add the missing unlock before return from function usbip_sockfd_store() > in the error handling case. > > Fixes: bd8b82042269 ("usbip: vudc synchronize sysfs code paths") > Reported-by: Hulk Robot > Signed-off-by: Ye Bin > --- > drivers/usb/usbip/vudc_sysfs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/usbip/vudc_sysfs.c b/drivers/usb/usbip/vudc_sysfs.c > index f7633ee655a1..d1cf6b51bf85 100644 > --- a/drivers/usb/usbip/vudc_sysfs.c > +++ b/drivers/usb/usbip/vudc_sysfs.c > @@ -156,12 +156,14 @@ static ssize_t usbip_sockfd_store(struct device *dev, > tcp_rx = kthread_create(&v_rx_loop, &udc->ud, "vudc_rx"); > if (IS_ERR(tcp_rx)) { > sockfd_put(socket); > + mutex_unlock(&udc->ud.sysfs_lock); > return -EINVAL; > } > tcp_tx = kthread_create(&v_tx_loop, &udc->ud, "vudc_tx"); > if (IS_ERR(tcp_tx)) { > kthread_stop(tcp_rx); > sockfd_put(socket); > + mutex_unlock(&udc->ud.sysfs_lock); > return -EINVAL; > } > > -- > 2.25.4 > This breaks the build, are you sure you tested it???