From: Greg KH <gregkh@linuxfoundation.org>
To: Johan Hovold <johan@kernel.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: do not use tty class device for debugging
Date: Fri, 9 Apr 2021 16:06:04 +0200 [thread overview]
Message-ID: <YHBfTIJ3uh7SK0Hm@kroah.com> (raw)
In-Reply-To: <20210408150859.16868-1-johan@kernel.org>
On Thu, Apr 08, 2021 at 05:08:59PM +0200, Johan Hovold wrote:
> Use the port struct device rather than tty class device for debugging.
>
> Note that while USB serial doesn't support serdev yet (due to serdev not
> handling hotplugging), serdev ttys do not have a corresponding class
> device and would have been logged using a "(NULL device *):" prefix.
>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/usb/serial/metro-usb.c | 4 ++--
> drivers/usb/serial/upd78f0730.c | 7 +++----
> drivers/usb/serial/usb-serial.c | 32 ++++++++++++++++----------------
> 3 files changed, 21 insertions(+), 22 deletions(-)
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
prev parent reply other threads:[~2021-04-09 14:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 15:08 [PATCH] USB: serial: do not use tty class device for debugging Johan Hovold
2021-04-09 14:06 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHBfTIJ3uh7SK0Hm@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).