From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7659AC433B4 for ; Fri, 9 Apr 2021 14:06:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40C5F60FF1 for ; Fri, 9 Apr 2021 14:06:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233794AbhDIOGW (ORCPT ); Fri, 9 Apr 2021 10:06:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:51980 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232855AbhDIOGV (ORCPT ); Fri, 9 Apr 2021 10:06:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7A7CA61165; Fri, 9 Apr 2021 14:06:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617977167; bh=A++tGxLLYu0bdoyDhMCSlTwTXMIaIFQOaEUZQ9jm4xA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SsNv9s1aWpH8thPfA1YDD3gsORQfeZgYgVxvcrDY0T2SZITORc11DmHRaXyeuaTP7 fxuUmaIZvo14vSk54bxgj5BLdxU7ZLA/w/dysll00dN/Ar7JJgmTSwgC64eOJxDAUn pdFt0j/Daktr54mwgRROzYPwgdKjUvPGSfPp588Q= Date: Fri, 9 Apr 2021 16:06:04 +0200 From: Greg KH To: Johan Hovold Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: serial: do not use tty class device for debugging Message-ID: References: <20210408150859.16868-1-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210408150859.16868-1-johan@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Thu, Apr 08, 2021 at 05:08:59PM +0200, Johan Hovold wrote: > Use the port struct device rather than tty class device for debugging. > > Note that while USB serial doesn't support serdev yet (due to serdev not > handling hotplugging), serdev ttys do not have a corresponding class > device and would have been logged using a "(NULL device *):" prefix. > > Signed-off-by: Johan Hovold > --- > drivers/usb/serial/metro-usb.c | 4 ++-- > drivers/usb/serial/upd78f0730.c | 7 +++---- > drivers/usb/serial/usb-serial.c | 32 ++++++++++++++++---------------- > 3 files changed, 21 insertions(+), 22 deletions(-) Reviewed-by: Greg Kroah-Hartman