From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99DD3C47080 for ; Mon, 31 May 2021 12:34:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75CD561263 for ; Mon, 31 May 2021 12:34:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231463AbhEaMfi (ORCPT ); Mon, 31 May 2021 08:35:38 -0400 Received: from mga18.intel.com ([134.134.136.126]:42225 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231377AbhEaMfi (ORCPT ); Mon, 31 May 2021 08:35:38 -0400 IronPort-SDR: m5MIFJt4rpb+cdYmkkYmRVvhAPXZIpatJD4bDdpQhI/P+zuzIKrA699Q8pfEO8RgiGHdbugXgo e3qISxMpBm0w== X-IronPort-AV: E=McAfee;i="6200,9189,10000"; a="190711866" X-IronPort-AV: E=Sophos;i="5.83,237,1616482800"; d="scan'208";a="190711866" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2021 05:33:55 -0700 IronPort-SDR: CjjbPz5fMAuEqn0ZIyienNP5xgz4ay/aGLJGaCHoHm1ho8HO0ZKuk14puks00OFegbtWm8iAmh sajrjvAwN1Xw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,237,1616482800"; d="scan'208";a="549400165" Received: from kuha.fi.intel.com ([10.237.72.162]) by fmsmga001.fm.intel.com with SMTP; 31 May 2021 05:33:52 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Mon, 31 May 2021 15:33:52 +0300 Date: Mon, 31 May 2021 15:33:52 +0300 From: Heikki Krogerus To: Jun Li Cc: Greg Kroah-Hartman , Hans de Goede , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/2] usb: typec: mux: Remove requirement for the "orientation-switch" device property Message-ID: References: <20210526153548.61276-1-heikki.krogerus@linux.intel.com> <20210526153548.61276-3-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org > > > Oh no. This patch just landed into Greg's usb-next. I'll prepare the > > > revert. I'm sorry about this. > > > > Actually, if we always need that extra (boolean) device property to identify > > the device class when OF graph is used, > > Looks like yes, as we need a way to know if the current fwnode > is for the target device we are looking for, to return probe > defer correctly. > > > shouldn't we just do that always > > in fwnode_graph_devcon_match()? > > This depends on if we want to limit this to be a boolean property > (to mark this is the target fwnode), or make it to be more generic > so user can define it in its ->match(). > > Now there are only 2 users of it, role switch and typec mux, both work > as a boolean property for con_id. OK. Let's leave to the users for now. thanks, -- heikki