Re: DWC3 (PCI) software node double free on shutdown

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

On Wed, Jun 02, 2021 at 07:03:30PM +0300, Andy Shevchenko wrote:
> On Tue, Jun 1, 2021 at 5:57 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > On Tue, Jun 1, 2021 at 1:28 PM Heikki Krogerus
> > <heikki.krogerus@linux.intel.com> wrote:
> > >
> > > On Tue, Jun 01, 2021 at 12:50:18PM +0300, Andy Shevchenko wrote:
> > > > >From time to time I see this on shutdown.
> > > > I suspect this happens due to the device core trying to remove
> > > > software nodes when it should not.
> > >
> > > Yes, this is caused by the device_remove_properties() call in
> > > device_del(). We can't remove that quite yet unfortunately.
> > >
> > > Can you test if this fixes the problem:
> >
> > Thanks, I have pushed it to my repo and will monitor the behaviour for
> > a few days or so.
> 
> Unfortunately it does not prevent the issue from happening. Till now I
> have got it already twice (for dozen or so reboots).

OK, thanks. I'll try to think of something else. I guess if nothing
else works, we just have to remove that device_remove_properties()
call from device_del(). I believe there is only one user left for the
device_add_properties() function, so converting that to use software
nodes instead should not be a big problem.


thanks,

-- 
heikki