linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] usb: gadget: fsl: Re-enable driver for ARM SoCs
@ 2021-06-10  3:49 Joel Stanley
  2021-06-11  2:01 ` Joel Stanley
  0 siblings, 1 reply; 4+ messages in thread
From: Joel Stanley @ 2021-06-10  3:49 UTC (permalink / raw)
  To: Fabio Estevam, Peter Chen, Arnd Bergmann, Felipe Balbi
  Cc: linux-usb, linux-arm-kernel

The commit a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver")
dropped the ARCH_MXC dependency from USB_FSL_USB2, leaving it depending
solely on FSL_SOC.

FSL_SOC is powerpc only; it was briefly available on ARM in 2014 but was
removed by commit cfd074ad8600 ("ARM: imx: temporarily remove
CONFIG_SOC_FSL from LS1021A"). Therefore the driver can no longer be
enabled on ARM platforms.

This appears to be a mistake as arm64's ARCH_LAYERSCAPE and arm32
SOC_LS1021A SoCs use this symbol. It's enabled in these defconfigs:

arch/arm/configs/imx_v6_v7_defconfig:CONFIG_USB_FSL_USB2=y
arch/arm/configs/multi_v7_defconfig:CONFIG_USB_FSL_USB2=y
arch/powerpc/configs/mgcoge_defconfig:CONFIG_USB_FSL_USB2=y
arch/powerpc/configs/mpc512x_defconfig:CONFIG_USB_FSL_USB2=y

To fix, expand the dependencies so USB_FSL_USB2 can be enabled on the
ARM platforms, and with COMPILE_TEST.

Fixes: a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver")
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
v2: Fix spelling of ARCH_LAYERSCAPE
---
 drivers/usb/gadget/udc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig
index 8c614bb86c66..7348acbdc560 100644
--- a/drivers/usb/gadget/udc/Kconfig
+++ b/drivers/usb/gadget/udc/Kconfig
@@ -90,7 +90,7 @@ config USB_BCM63XX_UDC
 
 config USB_FSL_USB2
 	tristate "Freescale Highspeed USB DR Peripheral Controller"
-	depends on FSL_SOC
+	depends on FSL_SOC || ARCH_LAYERSCAPE || SOC_LS1021A || COMPILE_TEST
 	help
 	   Some of Freescale PowerPC and i.MX processors have a High Speed
 	   Dual-Role(DR) USB controller, which supports device mode.
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] usb: gadget: fsl: Re-enable driver for ARM SoCs
  2021-06-10  3:49 [PATCH v2] usb: gadget: fsl: Re-enable driver for ARM SoCs Joel Stanley
@ 2021-06-11  2:01 ` Joel Stanley
  2021-06-11  2:11   ` Leo Li
  0 siblings, 1 reply; 4+ messages in thread
From: Joel Stanley @ 2021-06-11  2:01 UTC (permalink / raw)
  To: Fabio Estevam, Peter Chen, Arnd Bergmann, Felipe Balbi,
	Shawn Guo, Li Yang, NXP Linux Team, Stephen Rothwell
  Cc: linux-usb, Linux ARM

On Thu, 10 Jun 2021 at 03:50, Joel Stanley <joel@jms.id.au> wrote:
>
> The commit a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver")
> dropped the ARCH_MXC dependency from USB_FSL_USB2, leaving it depending
> solely on FSL_SOC.
>
> FSL_SOC is powerpc only; it was briefly available on ARM in 2014 but was
> removed by commit cfd074ad8600 ("ARM: imx: temporarily remove
> CONFIG_SOC_FSL from LS1021A"). Therefore the driver can no longer be
> enabled on ARM platforms.
>
> This appears to be a mistake as arm64's ARCH_LAYERSCAPE and arm32
> SOC_LS1021A SoCs use this symbol. It's enabled in these defconfigs:
>
> arch/arm/configs/imx_v6_v7_defconfig:CONFIG_USB_FSL_USB2=y
> arch/arm/configs/multi_v7_defconfig:CONFIG_USB_FSL_USB2=y
> arch/powerpc/configs/mgcoge_defconfig:CONFIG_USB_FSL_USB2=y
> arch/powerpc/configs/mpc512x_defconfig:CONFIG_USB_FSL_USB2=y
>
> To fix, expand the dependencies so USB_FSL_USB2 can be enabled on the
> ARM platforms, and with COMPILE_TEST.

This didn't work out, as there's some missing clock initialisation
calls that were removed when fsl_mxc_udc was deleted:

arm-linux-gnueabi-ld: drivers/usb/gadget/udc/fsl_udc_core.o: in
function `fsl_udc_remove':
fsl_udc_core.c:(.text+0xc88): undefined reference to `fsl_udc_clk_release'
arm-linux-gnueabi-ld: drivers/usb/gadget/udc/fsl_udc_core.o: in
function `fsl_udc_probe':
fsl_udc_core.c:(.text+0x1c44): undefined reference to `fsl_udc_clk_init'
arm-linux-gnueabi-ld: fsl_udc_core.c:(.text+0x1dcc): undefined
reference to `fsl_udc_clk_finalize'
arm-linux-gnueabi-ld: fsl_udc_core.c:(.text+0x1fe8): undefined
reference to `fsl_udc_clk_release'

We could add them back, but it's not clear if this driver is still
maintained. I'm looking to the NXP people for input here.

Stephen has dropped the patch from today's -next. I suggest we drop
(or revert?) this patch from the USB tree while a solution is found.

Cheers,

Joel

>
> Fixes: a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver")
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> v2: Fix spelling of ARCH_LAYERSCAPE
> ---
>  drivers/usb/gadget/udc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig
> index 8c614bb86c66..7348acbdc560 100644
> --- a/drivers/usb/gadget/udc/Kconfig
> +++ b/drivers/usb/gadget/udc/Kconfig
> @@ -90,7 +90,7 @@ config USB_BCM63XX_UDC
>
>  config USB_FSL_USB2
>         tristate "Freescale Highspeed USB DR Peripheral Controller"
> -       depends on FSL_SOC
> +       depends on FSL_SOC || ARCH_LAYERSCAPE || SOC_LS1021A || COMPILE_TEST
>         help
>            Some of Freescale PowerPC and i.MX processors have a High Speed
>            Dual-Role(DR) USB controller, which supports device mode.
> --
> 2.30.2
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH v2] usb: gadget: fsl: Re-enable driver for ARM SoCs
  2021-06-11  2:01 ` Joel Stanley
@ 2021-06-11  2:11   ` Leo Li
  2021-06-11  7:22     ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Leo Li @ 2021-06-11  2:11 UTC (permalink / raw)
  To: Joel Stanley, Fabio Estevam, Peter Chen, Arnd Bergmann,
	Felipe Balbi, Shawn Guo, dl-linux-imx, Stephen Rothwell,
	Ran Wang
  Cc: linux-usb, Linux ARM



> -----Original Message-----
> From: Joel Stanley <joel@jms.id.au>
> Sent: Thursday, June 10, 2021 9:01 PM
> To: Fabio Estevam <festevam@gmail.com>; Peter Chen
> <peter.chen@nxp.com>; Arnd Bergmann <arnd@arndb.de>; Felipe Balbi
> <balbi@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Leo Li
> <leoyang.li@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; Stephen
> Rothwell <sfr@canb.auug.org.au>
> Cc: linux-usb@vger.kernel.org; Linux ARM <linux-arm-
> kernel@lists.infradead.org>
> Subject: Re: [PATCH v2] usb: gadget: fsl: Re-enable driver for ARM SoCs
> 
> On Thu, 10 Jun 2021 at 03:50, Joel Stanley <joel@jms.id.au> wrote:
> >
> > The commit a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the
> > driver") dropped the ARCH_MXC dependency from USB_FSL_USB2,
> leaving it
> > depending solely on FSL_SOC.
> >
> > FSL_SOC is powerpc only; it was briefly available on ARM in 2014 but
> > was removed by commit cfd074ad8600 ("ARM: imx: temporarily remove
> > CONFIG_SOC_FSL from LS1021A"). Therefore the driver can no longer be
> > enabled on ARM platforms.
> >
> > This appears to be a mistake as arm64's ARCH_LAYERSCAPE and arm32
> > SOC_LS1021A SoCs use this symbol. It's enabled in these defconfigs:
> >
> > arch/arm/configs/imx_v6_v7_defconfig:CONFIG_USB_FSL_USB2=y
> > arch/arm/configs/multi_v7_defconfig:CONFIG_USB_FSL_USB2=y
> > arch/powerpc/configs/mgcoge_defconfig:CONFIG_USB_FSL_USB2=y
> > arch/powerpc/configs/mpc512x_defconfig:CONFIG_USB_FSL_USB2=y
> >
> > To fix, expand the dependencies so USB_FSL_USB2 can be enabled on the
> > ARM platforms, and with COMPILE_TEST.
> 
> This didn't work out, as there's some missing clock initialisation calls that were
> removed when fsl_mxc_udc was deleted:
> 
> arm-linux-gnueabi-ld: drivers/usb/gadget/udc/fsl_udc_core.o: in function
> `fsl_udc_remove':
> fsl_udc_core.c:(.text+0xc88): undefined reference to `fsl_udc_clk_release'
> arm-linux-gnueabi-ld: drivers/usb/gadget/udc/fsl_udc_core.o: in function
> `fsl_udc_probe':
> fsl_udc_core.c:(.text+0x1c44): undefined reference to `fsl_udc_clk_init'
> arm-linux-gnueabi-ld: fsl_udc_core.c:(.text+0x1dcc): undefined reference to
> `fsl_udc_clk_finalize'
> arm-linux-gnueabi-ld: fsl_udc_core.c:(.text+0x1fe8): undefined reference to
> `fsl_udc_clk_release'
> 
> We could add them back, but it's not clear if this driver is still maintained. I'm
> looking to the NXP people for input here.

Adding Ran Wang to the loop.  I think we will maintain the driver to keep the legacy platforms working but will not add new users of this driver.

> 
> Stephen has dropped the patch from today's -next. I suggest we drop (or
> revert?) this patch from the USB tree while a solution is found.
> 
> Cheers,
> 
> Joel
> 
> >
> > Fixes: a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver")
> > Signed-off-by: Joel Stanley <joel@jms.id.au>
> > ---
> > v2: Fix spelling of ARCH_LAYERSCAPE
> > ---
> >  drivers/usb/gadget/udc/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/gadget/udc/Kconfig
> > b/drivers/usb/gadget/udc/Kconfig index 8c614bb86c66..7348acbdc560
> > 100644
> > --- a/drivers/usb/gadget/udc/Kconfig
> > +++ b/drivers/usb/gadget/udc/Kconfig
> > @@ -90,7 +90,7 @@ config USB_BCM63XX_UDC
> >
> >  config USB_FSL_USB2
> >         tristate "Freescale Highspeed USB DR Peripheral Controller"
> > -       depends on FSL_SOC
> > +       depends on FSL_SOC || ARCH_LAYERSCAPE || SOC_LS1021A ||
> > + COMPILE_TEST
> >         help
> >            Some of Freescale PowerPC and i.MX processors have a High Speed
> >            Dual-Role(DR) USB controller, which supports device mode.
> > --
> > 2.30.2
> >

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] usb: gadget: fsl: Re-enable driver for ARM SoCs
  2021-06-11  2:11   ` Leo Li
@ 2021-06-11  7:22     ` Greg KH
  0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2021-06-11  7:22 UTC (permalink / raw)
  To: Leo Li
  Cc: Joel Stanley, Fabio Estevam, Peter Chen, Arnd Bergmann,
	Felipe Balbi, Shawn Guo, dl-linux-imx, Stephen Rothwell,
	Ran Wang, linux-usb, Linux ARM

On Fri, Jun 11, 2021 at 02:11:27AM +0000, Leo Li wrote:
> 
> 
> > -----Original Message-----
> > From: Joel Stanley <joel@jms.id.au>
> > Sent: Thursday, June 10, 2021 9:01 PM
> > To: Fabio Estevam <festevam@gmail.com>; Peter Chen
> > <peter.chen@nxp.com>; Arnd Bergmann <arnd@arndb.de>; Felipe Balbi
> > <balbi@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Leo Li
> > <leoyang.li@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; Stephen
> > Rothwell <sfr@canb.auug.org.au>
> > Cc: linux-usb@vger.kernel.org; Linux ARM <linux-arm-
> > kernel@lists.infradead.org>
> > Subject: Re: [PATCH v2] usb: gadget: fsl: Re-enable driver for ARM SoCs
> > 
> > On Thu, 10 Jun 2021 at 03:50, Joel Stanley <joel@jms.id.au> wrote:
> > >
> > > The commit a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the
> > > driver") dropped the ARCH_MXC dependency from USB_FSL_USB2,
> > leaving it
> > > depending solely on FSL_SOC.
> > >
> > > FSL_SOC is powerpc only; it was briefly available on ARM in 2014 but
> > > was removed by commit cfd074ad8600 ("ARM: imx: temporarily remove
> > > CONFIG_SOC_FSL from LS1021A"). Therefore the driver can no longer be
> > > enabled on ARM platforms.
> > >
> > > This appears to be a mistake as arm64's ARCH_LAYERSCAPE and arm32
> > > SOC_LS1021A SoCs use this symbol. It's enabled in these defconfigs:
> > >
> > > arch/arm/configs/imx_v6_v7_defconfig:CONFIG_USB_FSL_USB2=y
> > > arch/arm/configs/multi_v7_defconfig:CONFIG_USB_FSL_USB2=y
> > > arch/powerpc/configs/mgcoge_defconfig:CONFIG_USB_FSL_USB2=y
> > > arch/powerpc/configs/mpc512x_defconfig:CONFIG_USB_FSL_USB2=y
> > >
> > > To fix, expand the dependencies so USB_FSL_USB2 can be enabled on the
> > > ARM platforms, and with COMPILE_TEST.
> > 
> > This didn't work out, as there's some missing clock initialisation calls that were
> > removed when fsl_mxc_udc was deleted:
> > 
> > arm-linux-gnueabi-ld: drivers/usb/gadget/udc/fsl_udc_core.o: in function
> > `fsl_udc_remove':
> > fsl_udc_core.c:(.text+0xc88): undefined reference to `fsl_udc_clk_release'
> > arm-linux-gnueabi-ld: drivers/usb/gadget/udc/fsl_udc_core.o: in function
> > `fsl_udc_probe':
> > fsl_udc_core.c:(.text+0x1c44): undefined reference to `fsl_udc_clk_init'
> > arm-linux-gnueabi-ld: fsl_udc_core.c:(.text+0x1dcc): undefined reference to
> > `fsl_udc_clk_finalize'
> > arm-linux-gnueabi-ld: fsl_udc_core.c:(.text+0x1fe8): undefined reference to
> > `fsl_udc_clk_release'
> > 
> > We could add them back, but it's not clear if this driver is still maintained. I'm
> > looking to the NXP people for input here.
> 
> Adding Ran Wang to the loop.  I think we will maintain the driver to keep the legacy platforms working but will not add new users of this driver.

Now reverted in my tree.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-06-11  7:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-10  3:49 [PATCH v2] usb: gadget: fsl: Re-enable driver for ARM SoCs Joel Stanley
2021-06-11  2:01 ` Joel Stanley
2021-06-11  2:11   ` Leo Li
2021-06-11  7:22     ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).