From: Greg KH <gregkh@linuxfoundation.org>
To: Linyu Yuan <linyyuan@codeaurora.org>
Cc: Oliver Neukum <oliver@neukum.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: cdc_eem: fix tx fixup skb leak
Date: Wed, 16 Jun 2021 17:05:44 +0200 [thread overview]
Message-ID: <YMoTSAHnSpmpen6l@kroah.com> (raw)
In-Reply-To: <20210616144044.20693-1-linyyuan@codeaurora.org>
On Wed, Jun 16, 2021 at 10:40:44PM +0800, Linyu Yuan wrote:
> when usbnet transmit a skb, eem fixup it in eem_tx_fixup(),
> if skb_copy_expand() failed, it return NULL,
> usbnet_start_xmit() will have no chance to free original skb.
>
> fix it by free orginal skb in eem_tx_fixup() first,
> then check skb clone status, if failed, return NULL to usbnet.
>
> Signed-off-by: Linyu Yuan <linyyuan@codeaurora.org>
> ---
> drivers/net/usb/cdc_eem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
What commit does this "Fix:"? Can you please add that to the
signed-off-by area?
thanks,
greg k-h
prev parent reply other threads:[~2021-06-16 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 14:40 [PATCH] net: cdc_eem: fix tx fixup skb leak Linyu Yuan
2021-06-16 15:05 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMoTSAHnSpmpen6l@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linyyuan@codeaurora.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).