From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Linyu Yuan <linyyuan@codeaurora.org>
Cc: Felipe Balbi <balbi@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Linyu Yuan <linyyuan@codeaurora.com>
Subject: Re: [PATCH v3] usb: gadget: eem: fix echo command packet response issue
Date: Thu, 17 Jun 2021 15:22:30 +0200 [thread overview]
Message-ID: <YMtMlmwuIU3YmwAq@kroah.com> (raw)
In-Reply-To: <20210616115142.34075-1-linyyuan@codeaurora.org>
On Wed, Jun 16, 2021 at 07:51:42PM +0800, Linyu Yuan wrote:
> From: Linyu Yuan <linyyuan@codeaurora.com>
>
> when receive eem echo command, it will send a response,
> but queue this response to the usb request which allocate
> from gadget device endpoint zero,
> and transmit the request to IN endpoint of eem interface.
>
> on dwc3 gadget, it will trigger following warning in function
> __dwc3_gadget_ep_queue(),
>
> if (WARN(req->dep != dep, "request %pK belongs to '%s'\n",
> &req->request, req->dep->name))
> return -EINVAL;
Is this really a problem? I am guessing the request will not work at
all? Or just warn and continue with it?
How was this ever working?
>
> fix it by allocating a usb request from IN endpoint of eem interface,
> and transmit the usb request to same IN endpoint of eem interface.
>
> Signed-off-by: Linyu Yuan <linyyuan@codeaurora.com>
> ---
What commit does this fix? Should it be backported to older stable
kernels? If so, how far back?
thanks,
greg k-h
next prev parent reply other threads:[~2021-06-17 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 11:51 [PATCH v3] usb: gadget: eem: fix echo command packet response issue Linyu Yuan
2021-06-17 13:22 ` Greg Kroah-Hartman [this message]
2021-06-18 1:19 ` linyyuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMtMlmwuIU3YmwAq@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linyyuan@codeaurora.com \
--cc=linyyuan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).