From: Greg KH <gregkh@linuxfoundation.org>
To: Hannu Hartikainen <hannu@hrtk.in>
Cc: linux-usb@vger.kernel.org, Oliver Neukum <oneukum@suse.com>
Subject: Re: [PATCH] USB: cdc-acm: blacklist Heimann USB Appset device
Date: Tue, 22 Jun 2021 21:54:31 +0200 [thread overview]
Message-ID: <YNI/9/gbehhaNC1t@kroah.com> (raw)
In-Reply-To: <20210622141454.337948-1-hannu@hrtk.in>
On Tue, Jun 22, 2021 at 05:14:54PM +0300, Hannu Hartikainen wrote:
> The device (32a7:0000 Heimann Sensor GmbH USB appset demo) claims to be
> a CDC-ACM device in its descriptors but in fact is not. If it is run
> with echo disabled it returns garbled data, probably due to something
> that happens in the TTY layer. And when run with echo enabled (the
> default), it will mess up the calibration data of the sensor the first
> time any data is sent to the device.
>
> In short, I had a bad time after connecting the sensor and trying to get
> it to work. I hope blacklisting it in the cdc-acm driver will save
> someone else a bit of trouble.
>
> Signed-off-by: Hannu Hartikainen <hannu@hrtk.in>
> ---
>
> This is my first time submitting a patch. I hope I'll be able to submit
> a driver for this device later. The device is a microcontroller-based
> USB implementation/converter for a thermal camera that communicates over
> SPI.
>
> drivers/usb/class/cdc-acm.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> index ca7a61190dd9..d50b606d09aa 100644
> --- a/drivers/usb/class/cdc-acm.c
> +++ b/drivers/usb/class/cdc-acm.c
> @@ -1959,6 +1959,11 @@ static const struct usb_device_id acm_ids[] = {
> .driver_info = IGNORE_DEVICE,
> },
>
> + /* Exclude Heimann Sensor GmbH USB appset demo */
> + { USB_DEVICE(0x32a7, 0x0000),
> + .driver_info = IGNORE_DEVICE,
> + },
> +
If it's blacklisted here, what driver does control this device?
thanks,
greg k-h
next prev parent reply other threads:[~2021-06-22 19:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 14:14 [PATCH] USB: cdc-acm: blacklist Heimann USB Appset device Hannu Hartikainen
2021-06-22 19:54 ` Greg KH [this message]
2021-06-22 21:00 ` Hannu Hartikainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNI/9/gbehhaNC1t@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hannu@hrtk.in \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).