From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1B84C11F66 for ; Wed, 14 Jul 2021 08:38:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 91643613B0 for ; Wed, 14 Jul 2021 08:38:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238579AbhGNIl3 (ORCPT ); Wed, 14 Jul 2021 04:41:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238482AbhGNIl2 (ORCPT ); Wed, 14 Jul 2021 04:41:28 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B39EC06175F; Wed, 14 Jul 2021 01:38:37 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9EA68CC; Wed, 14 Jul 2021 10:38:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1626251915; bh=YbyFIqNHO3+cig/EdKRQenB4YdAV8pA1dPKaR9Ajrb0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pZ0PKnDxKLI8zEjX4dbxQdGSqpGC0WsyAIK8YFApt9/5WfEUne+DwoFdwe719/AfP q88kPyOc7s2GDRkoRX0SP6fZstxlduNZ7cq5hBJ6OQf97998wtga0XVb+HHu7oxcGp +ri5+FqXm+R52UKo3X+sPsPQYvQ0Z+iF5BLNOVbc= Date: Wed, 14 Jul 2021 11:38:34 +0300 From: Laurent Pinchart To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Boyd , Joerg Roedel , Will Deacon , Krzysztof Kozlowski , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Alessandro Zummo , Alexandre Belloni , Greg Kroah-Hartman , Sureshkumar Relli , Brian Norris , Kamal Dasu , Linus Walleij , Sebastian Siewior , linux-clk@vger.kernel.org, iommu@lists.linux-foundation.org, linux-mtd@lists.infradead.org, linux-rtc@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] dt-bindings: More dropping redundant minItems/maxItems Message-ID: References: <20210713193453.690290-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210713193453.690290-1-robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi Rob, Thank you for the patch. On Tue, Jul 13, 2021 at 01:34:53PM -0600, Rob Herring wrote: > Another round of removing redundant minItems/maxItems from new schema in > the recent merge window. > > If a property has an 'items' list, then a 'minItems' or 'maxItems' with the > same size as the list is redundant and can be dropped. Note that is DT > schema specific behavior and not standard json-schema behavior. The tooling > will fixup the final schema adding any unspecified minItems/maxItems. > > This condition is partially checked with the meta-schema already, but > only if both 'minItems' and 'maxItems' are equal to the 'items' length. > An improved meta-schema is pending. > > Cc: Stephen Boyd > Cc: Joerg Roedel > Cc: Will Deacon > Cc: Krzysztof Kozlowski > Cc: Miquel Raynal > Cc: Richard Weinberger > Cc: Vignesh Raghavendra > Cc: Alessandro Zummo > Cc: Alexandre Belloni > Cc: Greg Kroah-Hartman > Cc: Sureshkumar Relli > Cc: Brian Norris > Cc: Kamal Dasu > Cc: Linus Walleij > Cc: Sebastian Siewior > Cc: Laurent Pinchart > Cc: linux-clk@vger.kernel.org > Cc: iommu@lists.linux-foundation.org > Cc: linux-mtd@lists.infradead.org > Cc: linux-rtc@vger.kernel.org > Cc: linux-usb@vger.kernel.org > Signed-off-by: Rob Herring Reviewed-by: Laurent Pinchart > --- > .../devicetree/bindings/clock/brcm,iproc-clocks.yaml | 1 - > .../devicetree/bindings/iommu/rockchip,iommu.yaml | 2 -- > .../bindings/memory-controllers/arm,pl353-smc.yaml | 1 - > Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml | 8 -------- > .../devicetree/bindings/rtc/faraday,ftrtc010.yaml | 1 - > Documentation/devicetree/bindings/usb/nxp,isp1760.yaml | 2 -- > 6 files changed, 15 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.yaml b/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.yaml > index 8dc7b404ee12..1174c9aa9934 100644 > --- a/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.yaml > +++ b/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.yaml > @@ -50,7 +50,6 @@ properties: > > reg: > minItems: 1 > - maxItems: 3 > items: > - description: base register > - description: power register > diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml > index d2e28a9e3545..ba9124f721f1 100644 > --- a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml > +++ b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml > @@ -28,14 +28,12 @@ properties: > - description: configuration registers for MMU instance 0 > - description: configuration registers for MMU instance 1 > minItems: 1 > - maxItems: 2 > > interrupts: > items: > - description: interruption for MMU instance 0 > - description: interruption for MMU instance 1 > minItems: 1 > - maxItems: 2 > > clocks: > items: > diff --git a/Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.yaml b/Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.yaml > index 7a63c85ef8c5..01c9acf9275d 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/arm,pl353-smc.yaml > @@ -57,7 +57,6 @@ properties: > > ranges: > minItems: 1 > - maxItems: 3 > description: | > Memory bus areas for interacting with the devices. Reflects > the memory layout with four integer values following: > diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml > index e5f1a33332a5..dd5a64969e37 100644 > --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml > +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml > @@ -84,7 +84,6 @@ properties: > > interrupts: > minItems: 1 > - maxItems: 3 > items: > - description: NAND CTLRDY interrupt > - description: FLASH_DMA_DONE if flash DMA is available > @@ -92,7 +91,6 @@ properties: > > interrupt-names: > minItems: 1 > - maxItems: 3 > items: > - const: nand_ctlrdy > - const: flash_dma_done > @@ -148,8 +146,6 @@ allOf: > then: > properties: > reg-names: > - minItems: 2 > - maxItems: 2 > items: > - const: nand > - const: nand-int-base > @@ -161,8 +157,6 @@ allOf: > then: > properties: > reg-names: > - minItems: 3 > - maxItems: 3 > items: > - const: nand > - const: nand-int-base > @@ -175,8 +169,6 @@ allOf: > then: > properties: > reg-names: > - minItems: 3 > - maxItems: 3 > items: > - const: nand > - const: iproc-idm > diff --git a/Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml b/Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml > index 657c13b62b67..056d42daae06 100644 > --- a/Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml > +++ b/Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml > @@ -30,7 +30,6 @@ properties: > maxItems: 1 > > clocks: > - minItems: 2 > items: > - description: PCLK clocks > - description: EXTCLK clocks. Faraday calls it CLK1HZ and says the clock > diff --git a/Documentation/devicetree/bindings/usb/nxp,isp1760.yaml b/Documentation/devicetree/bindings/usb/nxp,isp1760.yaml > index a88f99adfe8e..f238848ad094 100644 > --- a/Documentation/devicetree/bindings/usb/nxp,isp1760.yaml > +++ b/Documentation/devicetree/bindings/usb/nxp,isp1760.yaml > @@ -25,14 +25,12 @@ properties: > > interrupts: > minItems: 1 > - maxItems: 2 > items: > - description: Host controller interrupt > - description: Device controller interrupt in isp1761 > > interrupt-names: > minItems: 1 > - maxItems: 2 > items: > - const: host > - const: peripheral -- Regards, Laurent Pinchart