From: Greg KH <gregkh@linuxfoundation.org>
To: Petr Vorel <petr.vorel@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: Mainlining Linux Sunxi SoC AW USB
Date: Sat, 24 Jul 2021 12:29:57 +0200 [thread overview]
Message-ID: <YPvrpUZ/VRc0eHvA@kroah.com> (raw)
In-Reply-To: <YPvjYIsu0G0HSu5I@pevik>
On Sat, Jul 24, 2021 at 11:54:40AM +0200, Petr Vorel wrote:
> Hi,
>
> I'd like to cleanup and mainline Linux Sunxi SoC AW USB host driver [1].
Great!
> What are the most ugly parts which should be replaced? Loading module does not
> complain about anything?
> [267044.912155] awusb: loading out-of-tree module taints kernel.
That will be fixed by moving it into the tree.
> [267044.912257] awusb: module verification failed: signature and/or required key missing - tainting kernel
That shows a mis-match between you building a kernel and what keys were
used to build the distro kernel you are using.
> [267044.913399] usbcore: registered new interface driver allwinner
> [267044.913401] awusb: v0.5:AW USB driver
Looks fine.
> BTW should it go to the host/Kconfig or misc/Kconfig or elsewhere?
No idea, is this a host driver or does it control a USB device you plug
into the system?
> [1] https://github.com/linux-sunxi/sunxi-livesuite/blob/master/awusb/awusb.c
I looked at this, and it's a device driver, not a host controller
driver.
But it looks to need a userspace program for the ioctls, where is that
code at? And why does it need any ioctls at all?
Why is this even a driver at all, it looks like you can write a small
userspace program using libusb to do everything it does, right? What
exactly is this driver needed for?
thanks,
greg k-h
next prev parent reply other threads:[~2021-07-24 10:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 9:54 Mainlining Linux Sunxi SoC AW USB Petr Vorel
2021-07-24 10:29 ` Greg KH [this message]
2021-07-24 13:41 ` Petr Vorel
2021-07-24 14:17 ` Greg KH
2021-07-24 14:22 ` Petr Vorel
2021-07-24 14:45 ` [linux-sunxi] " Christopher Obbard
2021-07-24 14:54 ` Jernej Škrabec
2021-07-24 14:49 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPvrpUZ/VRc0eHvA@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=petr.vorel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).