linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Felipe Balbi <balbi@kernel.org>
Cc: Maxim Devaev <mdevaev@gmail.com>,
	sandeen@redhat.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: f_hid: idle uses the highest byte for duration
Date: Wed, 28 Jul 2021 08:41:53 +0200	[thread overview]
Message-ID: <YQD8MfEZxPHYhnrz@kroah.com> (raw)
In-Reply-To: <87mtq7t0ex.fsf@kernel.org>

On Wed, Jul 28, 2021 at 09:31:02AM +0300, Felipe Balbi wrote:
> 
> Hi,
> 
> Maxim Devaev <mdevaev@gmail.com> writes:
> 
> > SET_IDLE value must be shifted 8 bits to the right to get duration.
> > This confirmed by USBCV test.
> >
> > Signed-off-by: Maxim Devaev <mdevaev@gmail.com>
> 
> with Greg's Fixes addition:
> 
> Acked-by: Felipe Balbi <balbi@kernel.org>

Argh, just missed me committing this.  Thanks for the review, sorry it
missed getting added to the final commit :(

greg k-h

  reply	other threads:[~2021-07-28  6:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27 18:58 [PATCH] usb: gadget: f_hid: idle uses the highest byte for duration Maxim Devaev
2021-07-28  6:25 ` Greg KH
2021-07-28  6:28   ` Maxim Devaev
2021-07-28  6:31 ` Felipe Balbi
2021-07-28  6:41   ` Greg KH [this message]
2021-07-28  6:47     ` Felipe Balbi
2021-07-28  6:48     ` Maxim Devaev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQD8MfEZxPHYhnrz@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=balbi@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mdevaev@gmail.com \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).