linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Vasily Khoruzhick <anarsoul@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: Commit 8a7bf7510d1f ("USB: serial: pl2303: amend and tighten type detection") broke pl2303 driver for my adapter
Date: Thu, 29 Jul 2021 12:02:20 +0200	[thread overview]
Message-ID: <YQJ8rNbYhSwmZvbb@hovoldconsulting.com> (raw)
In-Reply-To: <CA+E=qVfWm=3iJ6UR3UzeM-Se5sBjT+xx8CAM2G4bP2NxqW6itg@mail.gmail.com>

On Tue, Jul 27, 2021 at 05:00:20PM -0700, Vasily Khoruzhick wrote:
> Hey,
> 
> My PL2303 adapter isn't working after I upgraded to 5.13.
> 
> Looks like the culprit is commit 8a7bf7510d1f ("USB: serial: pl2303:
> amend and tighten type detection").
> 
> It used to work fine in 5.12.x.
> 
> Now it fails like this:
> 
> [246872.298632] usb 1-1: new full-speed USB device number 14 using xhci_hcd
> [246872.440065] usb 1-1: New USB device found, idVendor=067b,
> idProduct=23c3, bcdDevice= 3.05
> [246872.440079] usb 1-1: New USB device strings: Mfr=1, Product=2,
> SerialNumber=3
> [246872.440085] usb 1-1: Product: USB-Serial Controller
> [246872.440089] usb 1-1: Manufacturer: Prolific Technology Inc.
> [246872.440093] usb 1-1: SerialNumber: CMA>b103Y23
> [246872.445098] pl2303 1-1:1.0: pl2303 converter detected
> [246872.445114] pl2303 1-1:1.0: unknown device type, please report to
> linux-usb@vger.kernel.org

Thanks for the report. Can you please post the output of lsusb -v for
this device?

> Any ideas on how to fix it properly? Should I send a patch that
> handles bcdDevice == 0x305 and returns TYPE_HX for it from
> pl2303_detect_type()?

The device id indicates that this is in fact a PL2303GT so we may need
to amend the HXN type detection.

Johan

  reply	other threads:[~2021-07-29 10:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28  0:00 Commit 8a7bf7510d1f ("USB: serial: pl2303: amend and tighten type detection") broke pl2303 driver for my adapter Vasily Khoruzhick
2021-07-29 10:02 ` Johan Hovold [this message]
2021-07-29 17:37   ` Vasily Khoruzhick
2021-07-30 12:41     ` Johan Hovold
2021-08-04  6:41       ` Vasily Khoruzhick
2021-08-04  9:29         ` Johan Hovold
2021-08-04  9:31           ` [PATCH] USB: serial: pl2303: fix GT type detection Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQJ8rNbYhSwmZvbb@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=anarsoul@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).