From: Greg KH <gregkh@linuxfoundation.org>
To: nil Yi <teroincn@gmail.com>
Cc: johan@kernel.org, linux-usb@vger.kernel.org
Subject: Re: [BUG]drivers: usb: serial: mos7840.c: dangling pointer in function mos7840_open
Date: Sun, 1 Aug 2021 14:15:15 +0200 [thread overview]
Message-ID: <YQaQU0hkHQRcdjRC@kroah.com> (raw)
In-Reply-To: <CANTwqXBzZaPGomgsy00RhgTHvETWEXg_ZiL1ujgKmEU2TUsc_A@mail.gmail.com>
On Sun, Aug 01, 2021 at 05:03:30PM +0800, nil Yi wrote:
> Hi, there is a dangling pointer in mos7840_port->write_urb_pool[j] in function
> mos7840_open in v5.14-rc3.
>
> in function mos7840_open err path :
>
> 717: err:
> 718: for (j = 0; j < NUM_URBS; ++j) {
> 719: urb = mos7840_port->write_urb_pool[j];
> 720: if (!urb)
> 721: continue;
> 722: kfree(urb->transfer_buffer);
> 723: usb_free_urb(urb);
> }
>
> leave a dangling pointer here, I'm not sure whether it can be
> triggered somewhere.
What exactly do you mean by "dangling pointer"? What specifically is
the bug here?
thanks,
greg k-h
next prev parent reply other threads:[~2021-08-01 12:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-01 9:03 [BUG]drivers: usb: serial: mos7840.c: dangling pointer in function mos7840_open nil Yi
2021-08-01 12:15 ` Greg KH [this message]
2021-08-07 3:45 ` nil Yi
2021-08-07 5:20 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQaQU0hkHQRcdjRC@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=teroincn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).