linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Vasily Khoruzhick <anarsoul@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: Commit 8a7bf7510d1f ("USB: serial: pl2303: amend and tighten type detection") broke pl2303 driver for my adapter
Date: Wed, 4 Aug 2021 11:29:55 +0200	[thread overview]
Message-ID: <YQpeE19WIeQO2b//@hovoldconsulting.com> (raw)
In-Reply-To: <CA+E=qVcLdZ=gdJa-nV42ey751Dd9gFHWya7v=-y3WejoDYkaHA@mail.gmail.com>

On Tue, Aug 03, 2021 at 11:41:33PM -0700, Vasily Khoruzhick wrote:
> On Fri, Jul 30, 2021 at 5:42 AM Johan Hovold <johan@kernel.org> wrote:
> > On Thu, Jul 29, 2021 at 10:37:00AM -0700, Vasily Khoruzhick wrote:
> > > On Thu, Jul 29, 2021 at 3:02 AM Johan Hovold <johan@kernel.org> wrote:

> > > Bus 001 Device 024: ID 067b:23c3 Prolific Technology, Inc. USB-Serial
> > > Controller
> > > Device Descriptor:
> > >   bLength                18
> > >   bDescriptorType         1
> > >   bcdUSB               2.00
> > >   bDeviceClass            0
> > >   bDeviceSubClass         0
> > >   bDeviceProtocol         0
> > >   bMaxPacketSize0        64
> > >   idVendor           0x067b Prolific Technology, Inc.
> > >   idProduct          0x23c3
> > >   bcdDevice            3.05
> >
> > Thanks. Based on the above it looks like either a TA using the default
> > GT idProduct and new subminor release number (3.05), or it's a GT with
> > an undocumented release number (the datasheet says it should be 1.00).

> > Could you try applying the patch below and check the log for that
> > pl2303_supports_hx_status() printk? If it is indeed a GT then this
> > should also make the device work again.
> 
> Thanks, with this patch it works:
> 
> [793566.912312] usb 1-1: new full-speed USB device number 43 using xhci_hcd
> [793567.053688] usb 1-1: New USB device found, idVendor=067b,
> idProduct=23c3, bcdDevice= 3.05
> [793567.053702] usb 1-1: New USB device strings: Mfr=1, Product=2,
> SerialNumber=3
> [793567.053708] usb 1-1: Product: USB-Serial Controller
> [793567.053712] usb 1-1: Manufacturer: Prolific Technology Inc.
> [793567.053716] usb 1-1: SerialNumber: CMA>b103Y23
> [793567.056684] pl2303 1-1:1.0: pl2303 converter detected
> [793567.056956] pl2303 1-1:1.0: pl2303_supports_hx_status - ret = -32
> [793567.057281] usb 1-1: pl2303 converter now attached to ttyUSB0
> 
> I tested it with picocom at 115200 baud.
> 
> You can have my:
> 
> Tested-by: Vasily Khoruzhick <anarsoul@gmail.com>

Thanks for testing. I'll reply with a patch to get this fixed in 5.14-rc
and backported to 5.13.

Johan

  reply	other threads:[~2021-08-04  9:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28  0:00 Commit 8a7bf7510d1f ("USB: serial: pl2303: amend and tighten type detection") broke pl2303 driver for my adapter Vasily Khoruzhick
2021-07-29 10:02 ` Johan Hovold
2021-07-29 17:37   ` Vasily Khoruzhick
2021-07-30 12:41     ` Johan Hovold
2021-08-04  6:41       ` Vasily Khoruzhick
2021-08-04  9:29         ` Johan Hovold [this message]
2021-08-04  9:31           ` [PATCH] USB: serial: pl2303: fix GT type detection Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQpeE19WIeQO2b//@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=anarsoul@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).