From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jeaho Hwang <jhhwang@rtst.co.kr>
Cc: Peter Chen <peter.chen@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: chipidea: add loop timeout for hw_ep_set_halt()
Date: Fri, 13 Aug 2021 09:08:10 +0200 [thread overview]
Message-ID: <YRYaWgiWmO0lHcPg@kroah.com> (raw)
In-Reply-To: <20210809112048.GA3319230@ubuntu>
On Mon, Aug 09, 2021 at 08:20:48PM +0900, Jeaho Hwang wrote:
> If ctrl EP priming is failed (very rare case in standard linux),
> hw_ep_set_halt goes infinite loop. 50 was enough for zynq7000.
>
> Signed-off-by: Jeaho Hwang <jhhwang@rtst.co.kr>
> ---
> drivers/usb/chipidea/udc.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
> index d0cd1de1b6c7..92ca0b7e4310 100644
> --- a/drivers/usb/chipidea/udc.c
> +++ b/drivers/usb/chipidea/udc.c
> @@ -210,6 +210,9 @@ static int hw_ep_prime(struct ci_hdrc *ci, int num, int dir, int is_ctrl)
> return 0;
> }
>
> +/*will it be enough?*/
Please use ' ' characters in your comments.
And can you answer this, please do not add a question in a comment, be
sure about this.
> +#define HW_EP_SET_HALT_COUNT_MAX 100
> +
> /**
> * hw_ep_set_halt: configures ep halt & resets data toggle after clear (execute
> * without interruption)
> @@ -222,6 +225,7 @@ static int hw_ep_prime(struct ci_hdrc *ci, int num, int dir, int is_ctrl)
> */
> static int hw_ep_set_halt(struct ci_hdrc *ci, int num, int dir, int value)
> {
> + int count = HW_EP_SET_HALT_COUNT_MAX;
> if (value != 0 && value != 1)
Please use checkpatch.pl when submitting patches :(
prev parent reply other threads:[~2021-08-13 7:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 11:20 [PATCH] usb: chipidea: add loop timeout for hw_ep_set_halt() Jeaho Hwang
2021-08-13 7:08 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRYaWgiWmO0lHcPg@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jhhwang@rtst.co.kr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).